Re: [PATCH v2 3/3] search: Support automatic tag exclusions

Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions

Date: Mon, 16 Jan 2012 09:12:38 +0000

To: Jameson Graef Rollins, Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Edmondson


On Sat, 14 Jan 2012 15:40:26 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> This patch looks fine.  Philosophical UI discussion to follow:
> 
> On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > +    if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) {
> > +	const char *tags[] = { "deleted", "spam" };
> > +	notmuch_config_set_auto_exclude_tags (config, tags, 2);
> > +    }
> 
> This creates the config section with the exclude list pre-set to
> "deleted;spam".

I don't think that anything should be excluded from the search results
by default, at least not as a default behaviour of the 'notmuch'
binary.

Having "deleted" and "spam" as default settings in the configuration
file might be more reasonable.
part-000.sig (application/pgp-signature)

Thread: