Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

Subject: Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag

Date: Sun, 29 Jan 2012 10:37:01 +0000

To: Austin Clements

Cc: notmuch@notmuchmail.org

From: Mark Walters


> The cli stuff needs thought (about what it should do rather than
> how to do it).

Ok I have thought about the cli interface. My thoughts are as follows:

count/search/show should all have a --do-not-exclude option.

notmuch count:

        messages: just output count of matching not-excluded

        threads: count threads matching in a non-excluded message

notmuch search: 

        default/summary should output line as in the current patch with
        number matching being number non-excluded matching (so some will
        be zero)

        messages/files/tags should be matching not-excluded

        threads:  show thread ids of messages matching in a non-excluded message

notmuch show: 

        raw and part both deal with a single message so should output it
        regardless of exclude flags.

        text/json can give out the results including the exclude flag

        mbox only include matching not-excluded

The rationale is that all formats which can return an exclude flag do;
those that cannot omit the excluded results since the caller can just
call without setting the excludes if they want the full results.

Does that seem reasonable?

Best wishes

Mark

Thread: