Re: [PATCH v2 3/3] search: Support automatic tag exclusions

Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions

Date: Wed, 18 Jan 2012 00:52:09 -0800

To: David Edmondson, Austin Clements

Cc: notmuch@notmuchmail.org, Jeremy Nickurak

From: Jameson Graef Rollins


On Wed, 18 Jan 2012 08:38:23 +0000, David Edmondson <dme@dme.org> wrote:
> Something must create the initial configuration file if none exists. I'd
> be okay with that code adding 'deleted' and 'spam' to the excluded list.
>
> This would mean that an existing user would see no change without taking
> some action (adding the tags to the configuration file) and a new user
> would see the new behaviour (automatic exclusion).

What you describe is indeed how it currently works.  For new users or
old users who rerun setup, the config file will automatically include
the exclusions.  Otherwise, users will see no change.

> I'm not completely sure that automatically adding the exclusion of the
> specified tags via the configuration file for new users is a great
> idea. It seems as though it will lead to confusion for someone at some
> point.

Without any keys pre-bound to add "deleted" or "spam" tags, it probably
won't make much difference for new users.  And as long as it's
documented, users will be warned of the behavior.  Reading the config
file would also make it clear how the variable changes behavior.

jamie.
part-000.sig (application/pgp-signature)

Thread: