Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value

Subject: Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value

Date: Sun, 22 Jan 2012 07:55:05 +0100

To: Austin Clements

Cc: Notmuch Mail

From: Pieter Praet


On Thu, 19 Jan 2012 23:19:02 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> [...]
> Hah, okay.  How about this as an initial minor refactoring of the code
> for new.tags?
> [...]

Great, thanks!


Would the following commit message be satisfactory? :

  #+begin_quote
    setup: move tag printing and parsing into separate functions

    * notmuch-setup.c (notmuch_setup_command):
      Break tag printing and response parsing out into separate functions
      called `print_tag_list' respectively `parse_tag_list', for reuse
      with the 'search.exclude_tags' option.
  #+end_quote

(if not, please suggest an alternative; it'll be your name at the top)


Thanks again!


Peace

-- 
Pieter

Thread: