Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

Subject: Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup

Date: Sun, 22 Jan 2012 21:34:00 -0800

To: Pieter Praet, Xavier Maillard, Austin Clements

Cc: Notmuch Mail

From: Jameson Graef Rollins


On Mon, 23 Jan 2012 06:05:27 +0100, Pieter Praet <pieter@praet.org> wrote:
> You definitely have a point, but then again, who are we to assume that
> the terms "deleted" and "spam" have the *exact* same meaning for
> everyone?  (also see id:"8739bbo0br.fsf@praet.org")

Hrm.  I'm not sure I buy this.  Words already have meanings.  If we're
going to start down a rabbit hole where we have to assume that users are
making up crazy alternate meanings for words, we're going to run into a
lot of problems.

Notmuch, or at least the emacs interface, already assumes a specific
meaning for certain terms, like most notably "inbox".  Given that we're
dealing with english here, I think we have to assume common usage
meanings for any of the words we're using to describe anything.

This argument breaks a little in regards to "delete" since we're not
actually deleting anything in the sense of rm'ing it form the
filesystem, so we're already changing the meaning a bit.  But see below.

> IMHO, this is one of those options that should remain disabled until
> *explicitly* set by the user.

Ok, but then we're back to the incredibly prolonged discussion we've
been having about adding "delete" keys.  If we disable this by default,
but add "delete" keys, the user might be in for a different surprise if
"deleted" messages keep showing up in searches.

Basically we have two options as I see it:

- add keys bindings to add "deleted" tags, and then *also* exclude
  "tag:deleted" by default.

- don't exclude anything by default, but then don't add any special keys
  to handle "deleted" tags.

There seemed to be a consensus forming that we in fact did want to add
the "deleted" key bindings.  If we do that, then I think we should
generate the config file to exclude "deleted" tags by default.

jamie.

PS: when I say "exclude tags by default" I actually mean that the
setting should be added to the config file upon (re)generation.  Nothing
should be excluded if nothing is set in the config file.
part-000.sig (application/pgp-signature)

Thread: