Re: [PATCH v3 2/2] search: Support automatic tag exclusions

Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions

Date: Thu, 19 Jan 2012 15:28:39 -0500

To: Mark Walters

Cc: Notmuch Mail, Pieter Praet, Aaron Ecay

From: Austin Clements


Quoth Mark Walters on Jan 19 at  8:23 pm:
> 
> > On Thu, 19 Jan 2012 20:06:27 +0000, markwalters1009@gmail.com wrote:
> > > I would actually like make a different suggestion: extend
> > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see
> > > my deleted (ie hidden rather than actually deleted) messages return when
> > > viewing a thread.
> > 
> > It might be best to show the messages in the thread – after all, you
> > might want to “undelete” (or “unspam”) those messages in light of later
> > replies to them.  (And if you are sure you really want them gone, you
> > should be deleting them or moving them out of your maildir periodically,
> > rather than relying on notmuch to not show them to you ever.)
> 
> I am happy with them appearing as a non matching message, but currently
> they appear as a full open message. (The patch to achieve this is
> trivial: essentially transpose part of Austin's patch of
> notmuch-search.c into notmuch-show.c)

This definitely sounds like the right thing to do.  We can argue about
more sophisticated UIs, but it should do this at a minimum.

Thread: