Re: [PATCH v3 0/2] Automatic tag-based exclusion

Subject: Re: [PATCH v3 0/2] Automatic tag-based exclusion

Date: Mon, 16 Jan 2012 11:35:05 -0800

To: Austin Clements, notmuch@notmuchmail.org

Cc:

On Sat, 14 Jan 2012 19:17:32 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> This fixes the symbol visibility warning Jamie pointed out.

LGTM.  I'm using this now and it works like a charm.

jamie.

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search.

Thread:

Jameson Graef Rollins—another attempt to add delete functionality in emacs [inbox, unread]
- Jameson Graef Rollins—[PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search [inbox, notmuch::patch, notmuch::stale, unread]
  - Jameson Graef Rollins—[PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, notmuch::patch, notmuch::stale, unread]
    - Jameson Graef Rollins—[PATCH 3/4] emacs: add ability to "delete" messages and threads [inbox, notmuch::patch, notmuch::stale, unread]
      - Jameson Graef Rollins—[PATCH 4/4] emacs: modify help message for notmuch-search-line-faces to reflect preferred "deleted" tag name. [inbox, notmuch::patch, notmuch::stale, unread]
      - Jameson Graef Rollins—change to default archive/delete key bindings [inbox, unread]
        Jameson Graef Rollins—[PATCH 1/4] emacs: add show-mode functions to archive/delete only current message [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—[PATCH 2/4] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, notmuch::patch, notmuch::stale, unread]
        Jameson Graef Rollins—[PATCH 3/4] emacs: modify the default show-mode key bindings for archiving/deleting [inbox, notmuch::patch, notmuch::stale, unread]
        Jameson Graef Rollins—[PATCH 4/4] emacs: use pop-at-end functionality in archive/delete-message functions [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—[PATCH 4/4 v2] emacs: use pop-at-end functionality in archive/delete-message functions [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—[PATCH 4/4 v3] emacs: use pop-at-end functionality in archive/delete-message functions [inbox, unread]
        Aaron Ecay—Re: [PATCH 2/4] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end [inbox, unread]
        Jameson Graef Rollins—[PATCH 1/4 v2] emacs: add show-mode functions to archive/delete only current message [inbox, unread]
        David Edmondson—Re: [PATCH 1/4 v2] emacs: add show-mode functions to archive/delete only current message [inbox, signed, unread]
        David Edmondson—Re: change to default archive/delete key bindings [inbox, signed, unread]
    - Aaron Ecay—Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, unread]
      - Jameson Graef Rollins—Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, signed, unread]
        Aaron Ecay—Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, signed, unread]
        Aaron Ecay—Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 2/4] emacs: repurpose notmuch-show-archive-thread-internal function for general thread tagging [inbox, signed, unread]
  - Aaron Ecay—Re: [PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search [inbox, unread]
    - Austin Clements—Re: [PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search [inbox, unread]
      - Jameson Graef Rollins—Re: [PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search [inbox, signed, unread]
        Austin Clements—Re: [PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search [inbox, unread]
      - Austin Clements—Re: [PATCH 1/4] emacs: new customization variable to exclude "deleted" messages from search [inbox, unread]
        Austin Clements—[PATCH 0/3] Automatic tag-based exclusion [inbox, unread]
        Austin Clements—[PATCH 1/3] count: Convert to new-style argument parsing [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jani Nikula—Re: [PATCH 1/3] count: Convert to new-style argument parsing [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH 1/3] count: Convert to new-style argument parsing [inbox, unread]
        Jani Nikula—Re: [PATCH 1/3] count: Convert to new-style argument parsing [inbox, unread]
        Austin Clements—[PATCH 2/3] lib: Add support for automatically excluding tags from queries [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jani Nikula—Re: [PATCH 2/3] lib: Add support for automatically excluding tags from queries [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH 2/3] lib: Add support for automatically excluding tags from queries [inbox, unread]
        Austin Clements—[PATCH 3/3] search: Support automatic tag exclusions [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jani Nikula—Re: [PATCH 3/3] search: Support automatic tag exclusions [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 0/3] Automatic tag-based exclusion [inbox, signed, unread]
        Austin Clements—[PATCH v2 0/3] [inbox, unread]
        Austin Clements—[PATCH v2 1/3] count: Convert to new-style argument parsing [inbox, notmuch::patch, notmuch::pushed, unread]
        David Bremner—Re: [PATCH v2 1/3] count: Convert to new-style argument parsing [inbox, unread]
        Austin Clements—[PATCH v2 2/3] lib: Add support for automatically excluding tags from queries [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—Re: [PATCH v2 2/3] lib: Add support for automatically excluding tags from queries [inbox, notmuch::review, signed, unread]
        Austin Clements—Re: [PATCH v2 2/3] lib: Add support for automatically excluding tags from queries [inbox, unread]
        Austin Clements—[PATCH v2 3/3] search: Support automatic tag exclusions [inbox, notmuch::obsolete, notmuch::patch, unread]
        Jameson Graef Rollins—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, notmuch::review, signed, unread]
        Austin Clements—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, unread]
        David Edmondson—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        Austin Clements—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, unread]
        Jeremy Nickurak—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        David Edmondson—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        Austin Clements—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, unread]
        David Edmondson—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        David Edmondson—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH v2 3/3] search: Support automatic tag exclusions [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH v2 0/3] [inbox, notmuch::review, signed, unread]
        Austin Clements—[PATCH v3 0/2] Automatic tag-based exclusion [inbox, unread]
        Austin Clements—[PATCH v3 1/2] lib: Add support for automatically excluding tags from queries [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—[PATCH v3 2/2] search: Support automatic tag exclusions [inbox, notmuch::patch, notmuch::pushed, unread]
        Pieter Praet—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, notmuch::review, unread]
        Pieter Praet—[PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH 1/4] search: rename auto_exclude_tags to {search,}exclude_tags [inbox, notmuch::review, unread]
        Pieter Praet—Re: [PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags [inbox, notmuch::review, unread]
        Pieter Praet—[PATCH 2/4] test: only exclude "deleted" messages from search if explicitly configured [inbox, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
        Pieter Praet—[PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, notmuch::obsolete, notmuch::patch, unread]
        Xavier Maillard—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, signed, unread]
        Pieter Praet—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, signed, unread]
        Pieter Praet—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Jani Nikula—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, signed, unread]
        Jani Nikula—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, signed, unread]
        Pieter Praet—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Pieter Praet—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Jani Nikula—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Pieter Praet—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Pieter Praet—Re: [PATCH 3/4] config: only set search.exclude_tags to "deleted; spam; " during setup [inbox, unread]
        Pieter Praet—[PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, notmuch::review, unread]
        Pieter Praet—Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, unread]
        Austin Clements—Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, unread]
        Pieter Praet—Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, unread]
        Austin Clements—Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, unread]
        Pieter Praet—Re: [PATCH 4/4] setup: prompt user for search.exclude_tags value [inbox, unread]
        Pieter Praet—[PATCH v2 1/6] search: rename auto_exclude_tags to {search, }exclude_tags [inbox, notmuch::patch, notmuch::pushed, unread]
        David Bremner—Re: [PATCH v2 1/6] search: rename auto_exclude_tags to {search, }exclude_tags [inbox, unread]
        Pieter Praet—[PATCH v2 2/6] test: only exclude "deleted" messages from search if explicitly configured [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
        Pieter Praet—[PATCH v2 3/6] config: only exclude messages if 'search.exclude_tags' is explicitly set [inbox, notmuch::patch, notmuch::pushed, unread]
        Pieter Praet—[PATCH v2 4/6] setup: move tag printing and parsing into separate functions [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH v2 4/6] setup: move tag printing and parsing into separate functions [inbox, notmuch::review, unread]
        Pieter Praet—[PATCH v3 4/6] setup: Create functions for tag list printing and parsing [inbox, notmuch::patch, notmuch::pushed, unread]
        Pieter Praet—[PATCH v2 5/6] setup: prompt user for search.exclude_tags value [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH v2 5/6] setup: prompt user for search.exclude_tags value [inbox, notmuch::review, unread]
        Pieter Praet—[PATCH v3 5/6] setup: prompt user for search.exclude_tags value [inbox, notmuch::patch, notmuch::pushed, unread]
        Pieter Praet—[PATCH v2 6/6] NEWS: update "Tag exclusion" section [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH v2 6/6] NEWS: update "Tag exclusion" section [inbox, notmuch::review, unread]
        Pieter Praet—[PATCH v3 6/6] NEWS: update "Tag exclusion" section [inbox, notmuch::patch, notmuch::pushed, unread]
        Austin Clements—Re: [PATCH v3 6/6] NEWS: update "Tag exclusion" section [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        markwalters1009@gmail.com—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Aaron Ecay—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Mark Walters—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Austin Clements—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Mark Walters—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Mark Walters—[PATCH] Automatically exclude tags in notmuch-show [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, notmuch::review, unread]
        Pieter Praet—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Mark Walters—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Austin Clements—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Mark Walters—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Austin Clements—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Austin Clements—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Mark Walters—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Mark Walters—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Austin Clements—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Mark Walters—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Austin Clements—Re: [PATCH] Automatically exclude tags in notmuch-show [inbox, unread]
        Mark Walters—[RFC PATCH 1/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, notmuch::patch, notmuch::wip, unread]
        Mark Walters—[RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, notmuch::patch, notmuch::wip, unread]
        Austin Clements—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Austin Clements—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—[PATCH 1/4] Add exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
        Mark Walters—[PATCH 2/4] Add exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
        Mark Walters—[PATCH 3/4] Add exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
        Mark Walters—[PATCH 4/4] Add exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
        Mark Walters—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—[PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, notmuch::review, unread]
        Mark Walters—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, unread]
        Austin Clements—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, signed, unread]
        Jameson Graef Rollins—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, signed, unread]
        Austin Clements—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH 1/7] cli: add --do-not-exclude option to count and search. [inbox, signed, unread]
        Mark Walters—[PATCH 2/7] lib: Rearrange the exclude code in query.cc [inbox, notmuch::obsolete, notmuch::patch, unread]
        Mark Walters—[PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag [inbox, notmuch::review, unread]
        Mark Walters—Re: [PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag [inbox, unread]
        Austin Clements—Re: [PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag [inbox, unread]
        Mark Walters—Re: [PATCH 3/7] lib: Make notmuch_query_search_messages set the exclude flag [inbox, unread]
        Mark Walters—[PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads [inbox, notmuch::review, unread]
        Mark Walters—Re: [PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads [inbox, unread]
        Austin Clements—Re: [PATCH 4/7] lib: Add the exclude flag to notmuch_query_search_threads [inbox, notmuch::review, unread]
        Mark Walters—[PATCH 5/7] cli: Make notmuch-show respect excludes. [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [PATCH 5/7] cli: Make notmuch-show respect excludes. [inbox, notmuch::review, unread]
        Mark Walters—Re: [PATCH 5/7] cli: Make notmuch-show respect excludes. [inbox, unread]
        Mark Walters—[PATCH 6/7] cli: omit excluded messages in results where appropriate. [inbox, notmuch::obsolete, notmuch::patch, unread]
        Mark Walters—[PATCH 7/7] emacs: show: recognize the exclude flag. [inbox, notmuch::obsolete, notmuch::patch, unread]
        Austin Clements—Re: [RFC PATCH 2/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, notmuch::review, unread]
        Mark Walters—[RFC PATCH 3/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, notmuch::patch, notmuch::wip, unread]
        Austin Clements—Re: [RFC PATCH 3/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, unread]
        Mark Walters—[PATCH 4/4] Add NOTMUCH_MESSAGE_FLAG_EXCLUDED flag [inbox, notmuch::patch, notmuch::wip, unread]
        Pieter Praet—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Pieter Praet—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Xavier Maillard—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Pieter Praet—Re: [PATCH v3 2/2] search: Support automatic tag exclusions [inbox, unread]
        Jameson Graef Rollins—Re: [PATCH v3 0/2] Automatic tag-based exclusion [inbox, notmuch::review, signed, unread]
        David Bremner—Re: [PATCH v3 0/2] Automatic tag-based exclusion [inbox, unread]
        Austin Clements—[PATCH] News for tag exclusion [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
- David Edmondson—Re: another attempt to add delete functionality in emacs [inbox, signed, unread]
  - David Bremner—Re: another attempt to add delete functionality in emacs [inbox, unread]
    - Jameson Graef Rollins—Re: another attempt to add delete functionality in emacs [inbox, signed, unread]
      - Jani Nikula—Re: another attempt to add delete functionality in emacs [inbox, unread]
        Austin Clements—Re: another attempt to add delete functionality in emacs [inbox, unread]
      - David Edmondson—Re: another attempt to add delete functionality in emacs [inbox, signed, unread]
  - Jameson Graef Rollins—Re: another attempt to add delete functionality in emacs [inbox, signed, unread]