On Thu, Aug 06 2020, Jonas Bernoulli wrote: > David Bremner <david@tethera.net> writes: >> "cl-incf is a Lisp macro in ‘aquamacs-tools.el’." >> >> What the actual heck? > > Indeed. Did you follow the link to the definition to figure out what's > going on? > > Ah... I found this: https://github.com/dholm/tabbar/commit/6d5a6935879. > IMO it's wrong to do that, but that is of no concern here. > >> Anyway, that aside, what version of emacs is this available from? > > Emacs 24.3. A forward compatibility implementation for older versions > is available at https://elpa.gnu.org/packages/cl-lib.html. > > I didn't find any information about what minimal Emacs version Notmuch > expects but https://notmuchmail.org/emacstips/#index1h2 implies that it > is 24.1. > > IMO it would be reasonable to expect at least 24.3, 24.5 or even 25.1. > See https://www.gnu.org/software/emacs/history.html for release dates. NEWS for notmuch 0.29 says that: " The minimum supported major version of Emacs is now 24. Support for GNU Emacs older than 25.1 is deprecated with this release, and may be removed in a future release. " So we have 3 options: 1) apply this patch and now drop support for emacs 24 2) apply this patch and somehow infor emacs 24 users to install cl-lib from ELPA 3) hold this particular patch until notmuch 0.31 is released and drop support for emacs 24 then (would that mean quite a few following patches not to apply anymore ;/ Anyway, the patch series V2 looked good to me (on terminal) Tomi > > Or you might want to just drop this commit. Or we could update the FAQ > to mention that one has to install cl-lib from GNU ELPA if one uses such > an ancient Emacs release. > > Jonas _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org