Re: [PATCH 02/23] emacs: Remove excess empty lines

Subject: Re: [PATCH 02/23] emacs: Remove excess empty lines

Date: Mon, 27 Jul 2020 22:25:45 +0200

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Jonas Bernoulli


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Jul 26 2020, Jonas Bernoulli wrote:
>>  	;; Outer single and double quotes, which might be nested.
>>  	(cl-loop with start-of-loop
>> -		 do (setq start-of-loop p-name)
>> -
>> +		 do   (setq start-of-loop p-name)
>>  		 when (string-match "^\"\\(.*\\)\"$" p-name)
>> -		 do (setq p-name (match-string 1 p-name))
>> -
>> +		 do   (setq p-name (match-string 1 p-name))
>>  		 when (string-match "^'\\(.*\\)'$" p-name)
>> -		 do (setq p-name (match-string 1 p-name))
>> -
>> +		 do   (setq p-name (match-string 1 p-name))
>>  		 until (string= start-of-loop p-name)))

> These changes in spaces after `do` I don't understand...

IMO it looks a bit better when aligned with the `when' lines.  Since
these lines alternate with the lines that I modified because of the
stated reason of this commit, I felt that it was appropriate to make
this change as well.

But the alignment is an improvement is subjective and I would be happy
to change this.  I don't feel strongly about it.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: