[PATCH v3 00/34] A great number of cosmetic changes

Subject: [PATCH v3 00/34] A great number of cosmetic changes

Date: Sat, 8 Aug 2020 13:49:35 +0200

To: notmuch@notmuchmail.org

Cc:

From: Jonas Bernoulli

David Bremner <david@tethera.net> writes:

> Tomi Ollila <tomi.ollila@iki.fi> writes:

>> So we have 3 options:
>>
>> 1) apply this patch and now drop support for emacs 24
>>
>> 2) apply this patch and somehow infor emacs 24 users to install cl-lib from
>> ELPA
>
> I'm fine with either of these options. I'd hope we can specify what
> versions we need in emacs/notmuch-pkg.el.templ

I went with option 1: drop support for emacs 24.  Instead of just
adding a NEWS entry and bump a number, I also removed some old cruft
that was only necessary for emacs 24 (and in some cases emacs 23!).

That resulted in a few new commits of course, marked with * below.
And since I had to add some commit anyway, I also added three other
minor commits, marked with ^ below.

     Cheers,
     Jonas

Jonas Bernoulli (34):
  emacs: Shorten long lines
  emacs: Remove excess empty lines
  emacs: Fix indentation
  emacs: Closing parenthesis go on the same line
  emacs: Only set one variable per setq form
  emacs: Use 'and' instead of 'when' when the return value matters
  emacs: Use 'unless' instead of 'when' and 'not'
  emacs: Use 'when' instead of 'if' when there is no ELSE part
  emacs: Use one or three lines for 'if' forms
  emacs: Extend face to window edge again
  emacs: Fix some function declarations
  emacs: No longer define notmuch-hello-mode-map as a function
  emacs: notmuch-poll: Let the user know we are polling
  emacs: Use makefile-gmake-mode in Makefile*s
  emacs: Improve doc-strings
  emacs: Autoload notmuch-jump-search only once
  emacs: Autoload notmuch-jump using an autoload cookie
  emacs: Various cosmetic changes
  emacs: Increase consistency of library headers
  Fix typos
  .dir-locals.el: Set variables for correct "shell" mode
  test: Fix indentation
^ .gitignore: Sort using sort-lines
^ emacs: Provide 'rstdoc' feature at end of file
^ emacs: Add end-of-file line to libraries that lack it
* NEWS: Add stub for 0.31
* NEWS: At least Emacs 25.1 is required now
* emacs: Use cl-incf where appropriate
* emacs: Remove notmuch-setq-local
* emacs: Remove notmuch-read-char-choice
* emacs: Drop old advices that were only need for Emacs 23
* emacs: Do not abuse advice to monkey patch while testing
* emacs: Use new advice mechanism do advice mm-shr
* try-emacs-mua: Trim `require' advice for Emacs 25

 .dir-locals.el                             |   2 +-
 .gitignore                                 |  28 +-
 Makefile.global                            |   1 +
 Makefile.local                             |   2 +-
 NEWS                                       |  10 +-
 bindings/Makefile.local                    |   2 +-
 bindings/python-cffi/notmuch2/__init__.py  |   2 +-
 bindings/python-cffi/notmuch2/_base.py     |   6 +-
 bindings/python-cffi/notmuch2/_database.py |   8 +-
 bindings/python-cffi/notmuch2/_message.py  |   4 +-
 bindings/python-cffi/notmuch2/_tags.py     |   8 +-
 bindings/python-cffi/tests/conftest.py     |   2 +-
 bindings/python/notmuch/database.py        |  12 +-
 bindings/python/notmuch/query.py           |   2 +-
 compat/Makefile.local                      |   2 +-
 completion/Makefile.local                  |   2 +-
 devel/try-emacs-mua                        |  26 +-
 doc/Makefile.local                         |   2 +-
 emacs/Makefile.local                       |   2 +-
 emacs/coolj.el                             |  24 +-
 emacs/make-deps.el                         |   7 +-
 emacs/notmuch-address.el                   | 188 ++++-----
 emacs/notmuch-company.el                   |  56 +--
 emacs/notmuch-compat.el                    |  88 +----
 emacs/notmuch-crypto.el                    |  49 ++-
 emacs/notmuch-draft.el                     |  24 +-
 emacs/notmuch-hello.el                     | 102 +++--
 emacs/notmuch-jump.el                      |  61 ++-
 emacs/notmuch-lib.el                       | 202 +++++-----
 emacs/notmuch-maildir-fcc.el               | 122 +++---
 emacs/notmuch-message.el                   |   3 +-
 emacs/notmuch-mua.el                       | 185 ++++-----
 emacs/notmuch-parser.el                    |  16 +-
 emacs/notmuch-pkg.el.tmpl                  |   3 +-
 emacs/notmuch-print.el                     |   2 +-
 emacs/notmuch-query.el                     |  29 +-
 emacs/notmuch-show.el                      | 439 ++++++++++-----------
 emacs/notmuch-tag.el                       |  43 +-
 emacs/notmuch-tree.el                      | 189 ++++-----
 emacs/notmuch-version.el.tmpl              |   3 +-
 emacs/notmuch-wash.el                      | 109 +++--
 emacs/notmuch.el                           | 278 ++++++-------
 emacs/rstdoc.el                            |  22 +-
 lib/Makefile.local                         |   2 +-
 lib/notmuch.h                              |   4 +-
 parse-time-string/Makefile.local           |   2 +
 performance-test/Makefile.local            |   2 +-
 tag-util.c                                 |   2 +-
 tag-util.h                                 |   2 +-
 test/Makefile.local                        |   2 +-
 test/T310-emacs.sh                         |  14 +-
 test/T610-message-property.sh              |   2 +-
 test/T710-message-id.sh                    |   2 +-
 test/emacs-address-cleaning.el             |   2 +-
 test/random-corpus.c                       |   2 +-
 test/test-lib.el                           |  64 +--
 test/test-lib.sh                           |  36 +-
 util/Makefile.local                        |   2 +-
 58 files changed, 1188 insertions(+), 1319 deletions(-)

-- 
2.28.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: