Re: [PATCH 00/23] A great number of cosmetic changes

Subject: Re: [PATCH 00/23] A great number of cosmetic changes

Date: Sat, 01 Aug 2020 22:48:22 +0200

To: Tomi Ollila,


From: Jonas Bernoulli

Tomi Ollila <> writes:

> Series looks good to me (as far as I can tell). That one comment
> indentation in is what popped up
> in my review (I did review only diff patch, and don't know how that
> actually look -- like in those spaces after do in my previous reply, those
> look good to me now)

Thanks for the review.  Should I send a v2 now or wait a bit to see if
someone else spots any issues?

> One thing that come into my minw while browsing through patches -- does
> changing if's to when's accumulate any bloat -- or does byte compiler
> optimize that "extra" 'progn out in  (list 'if cond (cons 'progn body))).

I don't think the byte-compiler optimizes this away.  Some macros use
`macroexp-progn' instead of `progn' to take care of this.  I am guessing
that `when' doesn't use it because "subr.el" has to be loaded before

I think that's okay.

notmuch mailing list --
To unsubscribe send an email to