Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters

Subject: Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters

Date: Mon, 27 Jul 2020 00:02:39 +0200

To: Sean Whitton, notmuch@notmuchmail.org

Cc:

Sean Whitton <spwhitton@spwhitton.name> writes:

> On Sun 26 Jul 2020 at 06:58PM +02, Jonas Bernoulli wrote:
>
>> Also do so for some 'if' forms that lack an ELSE part.
>> Even go as far as using 'and' and 'not' instead of 'unless'.
>
> I don't follow "when the return value matters", could you explain?

As in "when the caller consumes the returned value".  The alternative
would be for the caller to not care about the value returned by the
callee and to instead call it for the side-effects only.

By using `and' we can signal that care about the return value and by
using `when' that we care about the side-effects instead.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH v3 00/34] A great number of cosmetic changes

Thread:

Jonas Bernoulli—[PATCH 00/23] A create number of cosmetic changes [inbox, unread]
- Jonas Bernoulli—[PATCH 01/23] emacs: Shorten long lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 01/23] emacs: Shorten long lines [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 01/23] emacs: Shorten long lines [inbox, unread]
- Jonas Bernoulli—[PATCH 02/23] emacs: Remove excess empty lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 02/23] emacs: Remove excess empty lines [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 02/23] emacs: Remove excess empty lines [inbox, unread]
- Jonas Bernoulli—[PATCH 03/23] emacs: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 03/23] emacs: Fix indentation [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 03/23] emacs: Fix indentation [inbox, unread]
- Jonas Bernoulli—[PATCH 04/23] emacs: Closing parenthesis go on the same line [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 05/23] emacs: Only set one variable per setq form [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 06/23] emacs: Use cl-incf where appropriate [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Sean Whitton—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
      - Sean Whitton—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
        Jonas Bernoulli—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
- Jonas Bernoulli—[PATCH 08/23] emacs: Use 'unless' instead of 'when' and 'not' [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 09/23] emacs: Use 'when' instead of 'if' when there is no ELSE part [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 10/23] emacs: Use one or three lines for 'if' forms [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 11/23] emacs: Extend face to window edge again [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 12/23] emacs: Fix some function declarations [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 13/23] emacs: No longer define notmuch-hello-mode-map as a function [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 14/23] emacs: notmuch-poll: Let the user know we are polling [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 15/23] emacs: Use makefile-gmake-mode in Makefile*s [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 16/23] emacs: Improve doc-strings [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 17/23] emacs: Autoload notmuch-jump-search only once [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 18/23] emacs: Autoload notmuch-jump using an autoload cookie [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 19/23] emacs: Various cosmetic changes [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 20/23] emacs: Increase consistency of library headers [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 21/23] Fix typos [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 22/23] .dir-locals.el: Set variables for correct "shell" mode [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 23/23] test: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
- Tomi Ollila—Re: [PATCH 00/23] A create number of cosmetic changes [inbox, unread]
  - Jonas Bernoulli—Re: [PATCH 00/23] A great number of cosmetic changes [inbox, unread]
    - David Bremner—Re: [PATCH 00/23] A great number of cosmetic changes [inbox, unread]
- Jonas Bernoulli—[PATCH v2 00/23] A great number of cosmetic changes [inbox, unread]
  - Jonas Bernoulli—[PATCH v2 01/23] emacs: Shorten long lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 02/23] emacs: Remove excess empty lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 03/23] emacs: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 04/23] emacs: Closing parenthesis go on the same line [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 05/23] emacs: Only set one variable per setq form [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
      - Jonas Bernoulli—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
        Tomi Ollila—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
        David Bremner—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
  - Jonas Bernoulli—[PATCH v2 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 08/23] emacs: Use 'unless' instead of 'when' and 'not' [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 09/23] emacs: Use 'when' instead of 'if' when there is no ELSE part [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 10/23] emacs: Use one or three lines for 'if' forms [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 11/23] emacs: Extend face to window edge again [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 12/23] emacs: Fix some function declarations [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 13/23] emacs: No longer define notmuch-hello-mode-map as a function [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 14/23] emacs: notmuch-poll: Let the user know we are polling [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 15/23] emacs: Use makefile-gmake-mode in Makefile*s [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 16/23] emacs: Improve doc-strings [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 17/23] emacs: Autoload notmuch-jump-search only once [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 18/23] emacs: Autoload notmuch-jump using an autoload cookie [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 19/23] emacs: Various cosmetic changes [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 20/23] emacs: Increase consistency of library headers [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 21/23] Fix typos [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 22/23] .dir-locals.el: Set variables for correct "shell" mode [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 23/23] test: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
  - Jonas Bernoulli—[PATCH v3 01/34] emacs: Shorten long lines [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 02/34] emacs: Remove excess empty lines [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 03/34] emacs: Fix indentation [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 04/34] emacs: Closing parenthesis go on the same line [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 05/34] emacs: Only set one variable per setq form [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 06/34] emacs: Use 'and' instead of 'when' when the return value matters [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 07/34] emacs: Use 'unless' instead of 'when' and 'not' [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 08/34] emacs: Use 'when' instead of 'if' when there is no ELSE part [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 09/34] emacs: Use one or three lines for 'if' forms [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 10/34] emacs: Extend face to window edge again [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 11/34] emacs: Fix some function declarations [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 12/34] emacs: No longer define notmuch-hello-mode-map as a function [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 13/34] emacs: notmuch-poll: Let the user know we are polling [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 14/34] emacs: Use makefile-gmake-mode in Makefile*s [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 15/34] emacs: Improve doc-strings [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 16/34] emacs: Autoload notmuch-jump-search only once [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 17/34] emacs: Autoload notmuch-jump using an autoload cookie [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 18/34] emacs: Various cosmetic changes [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 19/34] emacs: Increase consistency of library headers [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 20/34] Fix typos [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 21/34] .dir-locals.el: Set variables for correct "shell" mode [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 22/34] test: Fix indentation [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 23/34] .gitignore: Sort using sort-lines [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 24/34] emacs: Provide 'rstdoc' feature at end of file [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 25/34] emacs: Add end-of-file line to libraries that lack it [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 26/34] NEWS: Add stub for 0.31 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 27/34] NEWS: At least Emacs 25.1 is required now [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 28/34] emacs: Use cl-incf where appropriate [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 29/34] emacs: Remove notmuch-setq-local [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 30/34] emacs: Remove notmuch-read-char-choice [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 31/34] emacs: Drop old advices that were only need for Emacs 23 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 32/34] emacs: Do not abuse advice to monkey patch while testing [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 33/34] emacs: Use new advice mechanism do advice mm-shr [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 34/34] try-emacs-mua: Trim `require' advice for Emacs 25 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Tomi Ollila—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
  - David Bremner—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Đoàn Trần Công Danh—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
      - Jonas Bernoulli—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Tomi Ollila—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
      - David Bremner—Re: [PATCH v3 00/34] A great number of cosmetic changes [attachment, inbox, unread]