Re: [PATCH 03/23] emacs: Fix indentation

Subject: Re: [PATCH 03/23] emacs: Fix indentation

Date: Sat, 01 Aug 2020 22:37:02 +0200

To: Tomi Ollila, notmuch@notmuchmail.org

Cc:

From: Jonas Bernoulli


Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Sun, Jul 26 2020, Jonas Bernoulli wrote:

>> @@ -473,7 +473,7 @@ (defun notmuch-mua-new-forward-messages (messages &optional prompt-for-sender)
>>  	  (when (or prompt-for-sender notmuch-always-prompt-for-sender)
>>  	    (list (cons 'From (notmuch-mua-prompt-for-sender)))))
>>  	 forward-subject  ;; Comes from the first message and is
>> -			  ;; applied later.
>> +	 ;; applied later.
>
> Otherwise looks good (I think), but this change above... the indentation
> emacs does not work here. perhaps appending this 'applied later' to the end
> of previous line (even fits onto 80 columns, unlike the next comment...

I think we should fix that next comment and handle all three nearby
comments consistently, i.e.:

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -476,10 +476,12 @@ (defun notmuch-mua-new-forward-messages (messages &optional prompt-for-sender)
   (let* ((other-headers
          (and (or prompt-for-sender notmuch-always-prompt-for-sender)
               (list (cons 'From (notmuch-mua-prompt-for-sender)))))
-        forward-subject  ;; Comes from the first message and is
-                         ;; applied later.
-        forward-references ;; List of accumulated message-references of forwarded messages
-        forward-queries) ;; List of corresponding message-query
+        ;; Comes from the first message and is applied later.
+        forward-subject
+        ;; List of accumulated message-references of forwarded messages.
+        forward-references
+        ;; List of corresponding message-query.
+        forward-queries)
     ;; Generate the template for the outgoing message.
     (notmuch-mua-mail nil "" other-headers nil (notmuch-mua-get-switch-function))
     (save-excursion
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: