Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate

Subject: Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate

Date: Thu, 06 Aug 2020 15:37:50 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Jonas Bernoulli


David Bremner <david@tethera.net> writes:
> "cl-incf is a Lisp macro in ‘aquamacs-tools.el’."
>
> What the actual heck?

Indeed.  Did you follow the link to the definition to figure out what's
going on?

Ah... I found this: https://github.com/dholm/tabbar/commit/6d5a6935879.
IMO it's wrong to do that, but that is of no concern here.

> Anyway, that aside, what version of emacs is this available from?

Emacs 24.3.  A forward compatibility implementation for older versions
is available at https://elpa.gnu.org/packages/cl-lib.html.

I didn't find any information about what minimal Emacs version Notmuch
expects but https://notmuchmail.org/emacstips/#index1h2 implies that it
is 24.1.

IMO it would be reasonable to expect at least 24.3, 24.5 or even 25.1.
See https://www.gnu.org/software/emacs/history.html for release dates.

Or you might want to just drop this commit.  Or we could update the FAQ
to mention that one has to install cl-lib from GNU ELPA if one uses such
an ancient Emacs release.

     Jonas
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: