[PATCH v2 00/23] A great number of cosmetic changes

Subject: [PATCH v2 00/23] A great number of cosmetic changes

Date: Thu, 6 Aug 2020 09:18:47 +0200

Cc:

I have addressed the feedback from v1, making a change
to commit (1), leading to a minor conflict in commit (2).
Otherwise this is unchanged.

     Cheers,
     Jonas


Jonas Bernoulli (23):
  emacs: Shorten long lines
  emacs: Remove excess empty lines
1 emacs: Fix indentation
  emacs: Closing parenthesis go on the same line
  emacs: Only set one variable per setq form
  emacs: Use cl-incf where appropriate
2 emacs: Use 'and' instead of 'when' when the return value matters
  emacs: Use 'unless' instead of 'when' and 'not'
  emacs: Use 'when' instead of 'if' when there is no ELSE part
  emacs: Use one or three lines for 'if' forms
  emacs: Extend face to window edge again
  emacs: Fix some function declarations
  emacs: No longer define notmuch-hello-mode-map as a function
  emacs: notmuch-poll: Let the user know we are polling
  emacs: Use makefile-gmake-mode in Makefile*s
  emacs: Improve doc-strings
  emacs: Autoload notmuch-jump-search only once
  emacs: Autoload notmuch-jump using an autoload cookie
  emacs: Various cosmetic changes
  emacs: Increase consistency of library headers
  Fix typos
  .dir-locals.el: Set variables for correct "shell" mode
  test: Fix indentation

 .dir-locals.el                             |   2 +-
 Makefile.global                            |   1 +
 Makefile.local                             |   2 +-
 NEWS                                       |   2 +-
 bindings/Makefile.local                    |   2 +-
 bindings/python-cffi/notmuch2/__init__.py  |   2 +-
 bindings/python-cffi/notmuch2/_base.py     |   6 +-
 bindings/python-cffi/notmuch2/_database.py |   8 +-
 bindings/python-cffi/notmuch2/_message.py  |   4 +-
 bindings/python-cffi/notmuch2/_tags.py     |   8 +-
 bindings/python-cffi/tests/conftest.py     |   2 +-
 bindings/python/notmuch/database.py        |  12 +-
 bindings/python/notmuch/query.py           |   2 +-
 compat/Makefile.local                      |   2 +-
 completion/Makefile.local                  |   2 +-
 doc/Makefile.local                         |   2 +-
 emacs/Makefile.local                       |   2 +-
 emacs/coolj.el                             |  24 +-
 emacs/make-deps.el                         |   5 +-
 emacs/notmuch-address.el                   | 186 ++++-----
 emacs/notmuch-company.el                   |  53 ++-
 emacs/notmuch-compat.el                    |  99 +++--
 emacs/notmuch-crypto.el                    |  49 ++-
 emacs/notmuch-draft.el                     |  24 +-
 emacs/notmuch-hello.el                     | 102 +++--
 emacs/notmuch-jump.el                      |  61 ++-
 emacs/notmuch-lib.el                       | 204 +++++-----
 emacs/notmuch-maildir-fcc.el               | 122 +++---
 emacs/notmuch-message.el                   |   3 +-
 emacs/notmuch-mua.el                       | 189 +++++----
 emacs/notmuch-parser.el                    |  16 +-
 emacs/notmuch-print.el                     |   2 +-
 emacs/notmuch-query.el                     |  29 +-
 emacs/notmuch-show.el                      | 439 ++++++++++-----------
 emacs/notmuch-tag.el                       |  38 +-
 emacs/notmuch-tree.el                      | 189 ++++-----
 emacs/notmuch-wash.el                      | 109 +++--
 emacs/notmuch.el                           | 276 ++++++-------
 emacs/rstdoc.el                            |  18 +-
 lib/Makefile.local                         |   2 +-
 lib/notmuch.h                              |   4 +-
 parse-time-string/Makefile.local           |   2 +
 performance-test/Makefile.local            |   2 +-
 tag-util.c                                 |   2 +-
 tag-util.h                                 |   2 +-
 test/Makefile.local                        |   2 +-
 test/T610-message-property.sh              |   2 +-
 test/T710-message-id.sh                    |   2 +-
 test/emacs-address-cleaning.el             |   2 +-
 test/random-corpus.c                       |   2 +-
 test/test-lib.el                           |  43 +-
 test/test-lib.sh                           |  36 +-
 util/Makefile.local                        |   2 +-
 53 files changed, 1192 insertions(+), 1211 deletions(-)

-- 
2.28.0
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH v3 00/34] A great number of cosmetic changes

Thread:

Jonas Bernoulli—[PATCH 00/23] A create number of cosmetic changes [inbox, unread]
- Jonas Bernoulli—[PATCH 01/23] emacs: Shorten long lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 01/23] emacs: Shorten long lines [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 01/23] emacs: Shorten long lines [inbox, unread]
- Jonas Bernoulli—[PATCH 02/23] emacs: Remove excess empty lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 02/23] emacs: Remove excess empty lines [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 02/23] emacs: Remove excess empty lines [inbox, unread]
- Jonas Bernoulli—[PATCH 03/23] emacs: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Tomi Ollila—Re: [PATCH 03/23] emacs: Fix indentation [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 03/23] emacs: Fix indentation [inbox, unread]
- Jonas Bernoulli—[PATCH 04/23] emacs: Closing parenthesis go on the same line [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 05/23] emacs: Only set one variable per setq form [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 06/23] emacs: Use cl-incf where appropriate [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Sean Whitton—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
      - Sean Whitton—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
        Jonas Bernoulli—Re: [PATCH 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, unread]
- Jonas Bernoulli—[PATCH 08/23] emacs: Use 'unless' instead of 'when' and 'not' [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 09/23] emacs: Use 'when' instead of 'if' when there is no ELSE part [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 10/23] emacs: Use one or three lines for 'if' forms [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 11/23] emacs: Extend face to window edge again [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 12/23] emacs: Fix some function declarations [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 13/23] emacs: No longer define notmuch-hello-mode-map as a function [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 14/23] emacs: notmuch-poll: Let the user know we are polling [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 15/23] emacs: Use makefile-gmake-mode in Makefile*s [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 16/23] emacs: Improve doc-strings [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 17/23] emacs: Autoload notmuch-jump-search only once [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 18/23] emacs: Autoload notmuch-jump using an autoload cookie [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 19/23] emacs: Various cosmetic changes [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 20/23] emacs: Increase consistency of library headers [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 21/23] Fix typos [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 22/23] .dir-locals.el: Set variables for correct "shell" mode [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH 23/23] test: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
- Tomi Ollila—Re: [PATCH 00/23] A create number of cosmetic changes [inbox, unread]
  - Jonas Bernoulli—Re: [PATCH 00/23] A great number of cosmetic changes [inbox, unread]
    - David Bremner—Re: [PATCH 00/23] A great number of cosmetic changes [inbox, unread]
- Jonas Bernoulli—[PATCH v2 00/23] A great number of cosmetic changes [inbox, unread]
  - Jonas Bernoulli—[PATCH v2 01/23] emacs: Shorten long lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 02/23] emacs: Remove excess empty lines [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 03/23] emacs: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 04/23] emacs: Closing parenthesis go on the same line [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 05/23] emacs: Only set one variable per setq form [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
      - Jonas Bernoulli—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
        Tomi Ollila—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
        David Bremner—Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate [inbox, unread]
  - Jonas Bernoulli—[PATCH v2 07/23] emacs: Use 'and' instead of 'when' when the return value matters [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 08/23] emacs: Use 'unless' instead of 'when' and 'not' [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 09/23] emacs: Use 'when' instead of 'if' when there is no ELSE part [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 10/23] emacs: Use one or three lines for 'if' forms [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 11/23] emacs: Extend face to window edge again [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 12/23] emacs: Fix some function declarations [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 13/23] emacs: No longer define notmuch-hello-mode-map as a function [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 14/23] emacs: notmuch-poll: Let the user know we are polling [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 15/23] emacs: Use makefile-gmake-mode in Makefile*s [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 16/23] emacs: Improve doc-strings [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 17/23] emacs: Autoload notmuch-jump-search only once [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 18/23] emacs: Autoload notmuch-jump using an autoload cookie [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 19/23] emacs: Various cosmetic changes [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 20/23] emacs: Increase consistency of library headers [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 21/23] Fix typos [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 22/23] .dir-locals.el: Set variables for correct "shell" mode [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jonas Bernoulli—[PATCH v2 23/23] test: Fix indentation [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jonas Bernoulli—[PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
  - Jonas Bernoulli—[PATCH v3 01/34] emacs: Shorten long lines [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 02/34] emacs: Remove excess empty lines [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 03/34] emacs: Fix indentation [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 04/34] emacs: Closing parenthesis go on the same line [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 05/34] emacs: Only set one variable per setq form [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 06/34] emacs: Use 'and' instead of 'when' when the return value matters [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 07/34] emacs: Use 'unless' instead of 'when' and 'not' [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 08/34] emacs: Use 'when' instead of 'if' when there is no ELSE part [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 09/34] emacs: Use one or three lines for 'if' forms [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 10/34] emacs: Extend face to window edge again [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 11/34] emacs: Fix some function declarations [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 12/34] emacs: No longer define notmuch-hello-mode-map as a function [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 13/34] emacs: notmuch-poll: Let the user know we are polling [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 14/34] emacs: Use makefile-gmake-mode in Makefile*s [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
  - Jonas Bernoulli—[PATCH v3 15/34] emacs: Improve doc-strings [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 16/34] emacs: Autoload notmuch-jump-search only once [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 17/34] emacs: Autoload notmuch-jump using an autoload cookie [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 18/34] emacs: Various cosmetic changes [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 19/34] emacs: Increase consistency of library headers [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 20/34] Fix typos [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 21/34] .dir-locals.el: Set variables for correct "shell" mode [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 22/34] test: Fix indentation [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 23/34] .gitignore: Sort using sort-lines [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 24/34] emacs: Provide 'rstdoc' feature at end of file [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 25/34] emacs: Add end-of-file line to libraries that lack it [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 26/34] NEWS: Add stub for 0.31 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 27/34] NEWS: At least Emacs 25.1 is required now [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 28/34] emacs: Use cl-incf where appropriate [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 29/34] emacs: Remove notmuch-setq-local [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 30/34] emacs: Remove notmuch-read-char-choice [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 31/34] emacs: Drop old advices that were only need for Emacs 23 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 32/34] emacs: Do not abuse advice to monkey patch while testing [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 33/34] emacs: Use new advice mechanism do advice mm-shr [inbox, notmuch::patch, notmuch::pushed, unread]
  - Jonas Bernoulli—[PATCH v3 34/34] try-emacs-mua: Trim `require' advice for Emacs 25 [inbox, notmuch::patch, notmuch::pushed, unread]
  - Tomi Ollila—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
  - David Bremner—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Đoàn Trần Công Danh—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
      - Jonas Bernoulli—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Jonas Bernoulli—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
    - Tomi Ollila—Re: [PATCH v3 00/34] A great number of cosmetic changes [inbox, unread]
      - David Bremner—Re: [PATCH v3 00/34] A great number of cosmetic changes [attachment, inbox, unread]