Re: [PATCH v3 00/34] A great number of cosmetic changes

Subject: Re: [PATCH v3 00/34] A great number of cosmetic changes

Date: Sun, 09 Aug 2020 09:48:46 +0200

To: Tomi Ollila,


From: Jonas Bernoulli

Tomi Ollila <> writes:

> I made a quick check of release dates of emacs 25.1, gmime 3 and xapian 1.4
> -- gmime 3 released early 2017, xapian 1.4 middle of 2016 and emacs 25.1
> sept 2016 -- so requiring emacs 25.1 is pretty much aligned to those
> releases and therefore dropping emacs 24 support looks good to me.


>> That resulted in a few new commits of course, marked with * below.
>> And since I had to add some commit anyway, I also added three other
>> minor commits, marked with ^ below.
> I checked the new commits, looks good to me. I also was preparing dropping
> emacs 23 support code and the changes aligned what I tried. Interestinglyy
> this change in notmuch-mua.el:
>   ;; There is a bug in emacs 23's message.el that results in a newline
>   ;; not being inserted after the References header, so the next header
>   ;; is concatenated to the end of it. 
> Is still effective in emacs 26.3 -- I wonder whether there is something
> wrong notmuch-emacs handles the case `notmuch-mua-insert-references` is
> needed.

I'll have a look.

> I trust the earlier changes are the same as in v2 and v1

Almost. In "emacs: Increase consistency of library headers" I did bring
the headers of "notmuch-compat.el" and "emacs/notmuch-version.el.tmpl"
more in line.  But that's it.

notmuch mailing list --
To unsubscribe send an email to