Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Date: Sat, 7 Jan 2012 09:31:35 +0200

To: David Bremner

Cc: notmuch@notmuchmail.org

From: Jani Nikula

On Jan 7, 2012 5:52 AM, "David Bremner" <david@tethera.net> wrote:
>
> On Thu,  5 Jan 2012 22:25:12 +0200, Jani Nikula <jani@nikula.org> wrote:
> > notmuch_show_params_t params is only initialized partially in
> > notmuch_reply_command(). The only field that is used uninitialized is
> > params.decrypt. It is usually non-zero, making "notmuch reply" on
encrypted
> > messages work by coincidence.
>
> Hi Jani;
>
> I get one test failure with this patch on current master:

Can't investigate right now, but did you try with just patch 1/4? (I really
should have separated the bug fix from the rest.)

J.

>
>  FAIL   Reply within emacs
>        --- emacs.24.expected   2012-01-07 03:47:50.000000000 +0000
>        +++ emacs.24.output     2012-01-07 03:47:50.000000000 +0000
>        @@ -1,5 +1,5 @@
>         From: Notmuch Test Suite <test_suite@notmuchmail.org>
>        -To: user@example.com
>        +To:
>         Subject: Re: Testing message sent via SMTP
>         In-Reply-To: <XXX>
>         Fcc: /tmp/notmuch-dev-bremner/test/tmp.emacs/mail/sent
>
> d

Thread: