Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Date: Fri, 06 Jan 2012 23:52:15 -0400

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

On Thu,  5 Jan 2012 22:25:12 +0200, Jani Nikula <jani@nikula.org> wrote:
> notmuch_show_params_t params is only initialized partially in
> notmuch_reply_command(). The only field that is used uninitialized is
> params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted
> messages work by coincidence.

Hi Jani;

I get one test failure with this patch on current master:

 FAIL   Reply within emacs
	--- emacs.24.expected	2012-01-07 03:47:50.000000000 +0000
	+++ emacs.24.output	2012-01-07 03:47:50.000000000 +0000
	@@ -1,5 +1,5 @@
	 From: Notmuch Test Suite <test_suite@notmuchmail.org>
	-To: user@example.com
	+To: 
	 Subject: Re: Testing message sent via SMTP
	 In-Reply-To: <XXX>
	 Fcc: /tmp/notmuch-dev-bremner/test/tmp.emacs/mail/sent

d

Thread: