Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Date: Fri, 06 Jan 2012 07:57:41 -0400

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

On Fri, 06 Jan 2012 10:11:42 +0200, Jani Nikula <jani@nikula.org> wrote:

> IMHO the first is cleanest and unaffected by changes in
> notmuch_show_params_t, though might be surprising if you're not (yet)
> used to C99 designated initializers.

Obviously not ;). It would nice to have a consensus about the use of C99
features in the notmuch code. Personally I think it's fine, but I know
we have had some back and forth about e.g. mid-block variable declarations.

> In any case, in the current implementation only .part and .cryptoctx are
> initialized, and the rest of the fields are random. This needs to be
> fixed one way or another.

Agreed.

d

• Previous message (by thread): Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions

Thread:

• Jani Nikula—[PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
  • Jani Nikula—[PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
      • Jani Nikula—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
        • David Bremner—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
    • David Bremner—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
      • Jani Nikula—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
        • Mark Walters—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
        • David Bremner—Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
  • Jani Nikula—[PATCH 2/4] cli: convert "notmuch reply" to use the new argument parser [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH 3/4] cli: add support for replying just to the sender in "notmuch reply" [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH 4/4] emacs: add support for replying just to the sender of messages and threads [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jameson Graef Rollins—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, signed, unread]
    • Mueen Nawaz—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
  • Mark Walters—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
    • Jani Nikula—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
      • Mark Walters—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
        • Mark Walters—[PATCH 1/4] Add the option "--reply-to" to notmuch reply. [inbox, unread]
          • Jani Nikula—Re: [PATCH 1/4] Add the option "--reply-to" to notmuch reply. [inbox, unread]
            • Mark Walters—Re: [PATCH 1/4] Add the option "--reply-to" to notmuch reply. [inbox, unread]
              • Jani Nikula—Re: [PATCH 1/4] Add the option "--reply-to" to notmuch reply. [inbox, unread]
        • Mark Walters—[PATCH 2/4] Update the man page for notmuch-reply to give the syntax for the --reply-to option. [inbox, unread]
        • Mark Walters—[PATCH 3/4] Emacs changes for reply-to-sender [inbox, unread]
        • Mark Walters—[PATCH 4/4] add tests for reply-to-sender [inbox, unread]
      • Mark Walters—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
  • Adam Wolfe Gordon—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
    • Tomi Ollila—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, unread]
  • David Edmondson—Re: [PATCH 0/4] notmuch reply bugfix & reply to sender only [inbox, signed, unread]
  • Jani Nikula—[PATCH v2 0/6] reply to sender [inbox, unread]
    • Jani Nikula—[PATCH v2 1/6] cli: fix use of uninitialized variable in "notmuch reply" [inbox, unread]
    • Jani Nikula—[PATCH v2 2/6] cli: convert "notmuch reply" to use the new argument parser [inbox, unread]
    • Jani Nikula—[PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply" [inbox, unread]
      • Mark Walters—Re: [PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply" [inbox, unread]
        • Jani Nikula—Re: [PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply" [inbox, unread]
          • Mark Walters—Re: [PATCH v2 3/6] cli: add support for replying just to the sender in "notmuch reply" [inbox, unread]
    • Jani Nikula—[PATCH v2 4/6] emacs: add support for replying just to the sender [inbox, unread]
    • Jani Nikula—[PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, unread]
      • Jeremy Nickurak—Re: [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, signed, unread]
          • Jeremy Nickurak—Re: [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, unread]
        • Gregor Zattler—is there a default reply function? (was: Re: [PATCH v2 5/6] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all) [inbox, unread]
    • Jani Nikula—[PATCH v2 6/6] test: add tests for "notmuch reply" --reply-to=sender [inbox, unread]
    • David Edmondson—Re: [PATCH v2 0/6] reply to sender [inbox, notmuch::review, signed, unread]
    • Dmitry Kurochkin—Re: [PATCH v2 0/6] reply to sender [inbox, unread]
  • Jani Nikula—[PATCH v3 0/4] reply to sender [inbox, unread]
    • Jani Nikula—[PATCH v3 1/4] cli: add support for replying just to the sender in "notmuch reply" [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v3 1/4] cli: add support for replying just to the sender in "notmuch reply" [inbox, notmuch::review, unread]
    • Jani Nikula—[PATCH v3 2/4] emacs: add support for replying just to the sender [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Edmondson—Re: [PATCH v3 2/4] emacs: add support for replying just to the sender [inbox, notmuch::review, signed, unread]
        • Jani Nikula—Re: [PATCH v3 2/4] emacs: add support for replying just to the sender [inbox, unread]
          • David Edmondson—Re: [PATCH v3 2/4] emacs: add support for replying just to the sender [inbox, signed, unread]
        • Aaron Ecay—Re: [PATCH v3 2/4] emacs: add support for replying just to the sender [inbox, unread]
          • Jani Nikula—Re: [PATCH v3 2/4] emacs: add support for replying just to the sender [inbox, unread]
    • Jani Nikula—[PATCH v3 3/4] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Edmondson—Re: [PATCH v3 3/4] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, notmuch::review, signed, unread]
    • Jani Nikula—[PATCH v3 4/4] test: add tests for "notmuch reply" --reply-to=sender [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v3 4/4] test: add tests for "notmuch reply" --reply-to=sender [inbox, notmuch::review, unread]
        • Tomi Ollila—Re: [PATCH v3 4/4] test: add tests for "notmuch reply" --reply-to=sender [inbox, unread]
  • Jani Nikula—[PATCH v4 0/5] reply to sender [inbox, unread]
    • Jani Nikula—[PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, notmuch::review, unread]
        • Jani Nikula—Re: [PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, unread]
      • Mark Walters—Re: [PATCH v4 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, unread]
    • Jani Nikula—[PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply" [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply" [inbox, notmuch::review, unread]
      • Mark Walters—Re: [PATCH v4 2/5] cli: add support for replying just to the sender in "notmuch reply" [inbox, unread]
    • Jani Nikula—[PATCH v4 3/5] emacs: add support for replying just to the sender [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—[PATCH v4 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jani Nikula—[PATCH v4 5/5] test: add tests for "notmuch reply" --reply-to=sender [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jani Nikula—[PATCH v5 0/5] reply to sender [inbox, unread]
    • Jani Nikula—[PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, unread]
        • Jani Nikula—Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, unread]
        • Dmitry Kurochkin—Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, unread]
          • David Edmondson—Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, signed, unread]
          • David Bremner—Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, unread]
          • Jameson Graef Rollins—Re: [PATCH v5 1/5] cli: slightly refactor "notmuch reply" address scanning functions [inbox, signed, unread]
    • Jani Nikula—[PATCH v5 2/5] cli: add support for replying just to the sender in "notmuch reply" [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jani Nikula—[PATCH v5 3/5] emacs: add support for replying just to the sender [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jani Nikula—[PATCH v5 4/5] emacs: bind 'r' to reply-to-sender and 'R' to reply-to-all [inbox, notmuch::patch, notmuch::pushed, unread]
    • Jani Nikula—[PATCH v5 5/5] test: add tests for "notmuch reply" --reply-to=sender [inbox, notmuch::patch, notmuch::pushed, unread]