> That is a very good point, and one that my patch fails to address. > > > (*) I have a version of that patch-set which applies to master if that > > would be useful to anyone, and I recently started writing tests in > > preparation for re-submitting. > > Ah, it's old, no wonder I didn't know about it. Looking at the v2 of it > that I found gmane, it looks like the approach is roughly the same. > > I think me passing the 'add' parameter makes things a bit more obvious > and explicit, while your use of "g_mime_message_get_all_recipients > (reply) == NULL" might be more robust (including handling reply to > user's own message). Switching to new style argument parsing is probably > something David will insist on, and that's a ready, independent patch in > my set. On emacs side I think my patch is just slightly cleaner, but no > big difference. I have not had a chance to look at your code yet: I will try to do so this afternoon. > How about you post what you have now as a reply to this thread, and let > others be the judge? I really don't mind whether it's you or I who > finishes this as long as we get the feature, and preferrably combining > the best of what we both have. I'm also open to splitting this between > you and me; just let me know what you think. I will post it as a reply to this message. I don't mind which version goes in either (but it would be nice if some version did!) Best wishes Mark