Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply"

Date: Sat, 07 Jan 2012 08:14:46 -0400

To: Jani Nikula

Cc: notmuch@notmuchmail.org

From: David Bremner

On Sat, 7 Jan 2012 09:31:35 +0200, Jani Nikula <jani@nikula.org> wrote:
> On Jan 7, 2012 5:52 AM, "David Bremner" <david@tethera.net> wrote:
> >
> > On Thu,  5 Jan 2012 22:25:12 +0200, Jani Nikula <jani@nikula.org> wrote:
> > > notmuch_show_params_t params is only initialized partially in
> > > notmuch_reply_command(). The only field that is used uninitialized is
> > > params.decrypt. It is usually non-zero, making "notmuch reply" on
> encrypted
> > > messages work by coincidence.
> >
> > Hi Jani;
> >
> > I get one test failure with this patch on current master:
> 
> Can't investigate right now, but did you try with just patch 1/4? (I really
> should have separated the bug fix from the rest.)
> 
> J.
> 

Hi Jani;

I _thought_ I was applying just that one patch, but I can't duplicate
the error now, so I might have messed up using dme's new "patch
application wizard". So, nevermind, sorry for the noise.

d

Thread: