Re: [PATCH] emacs: add new option notmuch-search-exclude

Subject:Re: [PATCH] emacs: add new option notmuch-search-exclude

Date:Tue, 22 Mar 2022 13:27:53 +0000

To:David Bremner ,notmuch@notmuchmail.org

Cc:

From:Mohsin Kaleem


David Bremner <david@tethera.net> writes:

> Can you update the file devel/emacs-keybindings.org so we don't lose
> track of the bindings. Also, per the contributing guide [1], please
> add some brief documentation to the emacs docs in
> doc/notmuch-emacs.rst

Done.

> Also, we need at least one new test (ideally one per mode). There should
> be some tests you can crib from in T310-emacs.sh and T450-emacs-show.sh.

I'm more than happy to add some new tests but at least for me the test
suite appears to be failing on the master branch. I think it'd be easier
to wait until the existing tests are fixed before adding or changing new
ones.

-- 
Mohsin Kaleem
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: