Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded

Subject: Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded

Date: Sun, 07 May 2023 07:19:44 -0600

To: mohkale@kisara.moe, notmuch@notmuchmail.org

Cc: Mohsin Kaleem

From: David Bremner


mohkale@kisara.moe writes:

> Lastly I've amended some calls to notmuch-tree and notmuch-unthreaded
> which didn't pass through the buffer local value of
> notmuch-search-oldest-first (and now notmuch-search-exclude).
> Examples of where I've done this
>   + include notmuch-jump-search

if respinning, move 'include' to previous line

>
> If there was a reasoning behind these not persisting the value of these
> variables then we should revert it before merging and discuss whether
> it's worth persisting notmuch-search-exclude.
>

I think the fixes are fine, and make sense to include since you are
touching that code anyway. This sentence probably doesn't belong in the
commit message, so if respinning the series, I would drop it.

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: