Re: [PATCH] emacs: add new option notmuch-search-exclude

Subject: Re: [PATCH] emacs: add new option notmuch-search-exclude

Date: Fri, 25 Mar 2022 15:36:50 -0400

To: Mohsin Kaleem, notmuch@notmuchmail.org

Cc:

From: David Bremner

Mohsin Kaleem <mohkale@kisara.moe> writes:

> David Bremner <david@tethera.net> writes:
>
>> Try adding a line
>> "unset XDG_DATA_HOME"
>>
>> after
>>
>> unset XDG_CONFIG_HOME
>>
>> on line 108 of test/test-lib.sh
>
> Doesn't seem to be such a line in test/test-lib.sh, but I added it to
> test/test-vars.sh and we're down from 42 failing tests to 4 :-).

Ah right, I was looking at an old version.

>
> T391-python-cffi: Testing python bindings (pytest)
>  FAIL   python cffi tests (NOTMUCH_CONFIG set)
> 	(cd /home/mohkale/prog/repos/notmuch/bindings/python-cffi/build/stage && python3 -m pytest --verbose --log-file=/home/mohkale/prog/repos/notmuch/test/tmp.T391-python-cffi/test.output)
> /usr/bin/python3: No module named pytest
>  FAIL   python cffi tests (NOTMUCH_CONFIG unset)
> 	(cd /home/mohkale/prog/repos/notmuch/bindings/python-cffi/build/stage && python3 -m pytest --verbose --log-file=/home/mohkale/prog/repos/notmuch/test/tmp.T391-python-cffi/test.output)

So does "python3 -m pytest" work for you? Assuming yes, is there some
special environment needed? We don't explicitly unset PYTHONPATH in
T391, so in if you need PYTHONPATH to locate pytest, that should work
here as well. What output do you get from "python3 -c 'import pytest;
print(pytest.__file__)'"

> T560-lib-error: Testing error reporting for library
>  FAIL   Open null pointer
> 	--- T560-lib-error.2.EXPECTED	2022-03-22 20:25:30.496475869 +0000
> 	+++ T560-lib-error.2.OUTPUT	2022-03-22 20:25:30.496475869 +0000
> 	@@ -1,3 +1,2 @@
> 	 == stdout ==
> 	 == stderr ==
> 	-Error: could not locate database.
> test1.c: In function 'main':
> test1.c:7:5: warning: 'notmuch_database_open' is deprecated: function deprecated as of libnotmuch 5.4 [-Wdeprecated-declarations]
>     7 |     stat = notmuch_database_open (NULL, 0, 0);
>       |     ^~~~
> In file included from test1.c:2:
> /home/mohkale/prog/repos/notmuch/lib/notmuch.h:332:1: note: declared here
>   332 | notmuch_database_open (const char *path,
>       | ^~~~~~~~~~~~~~~~~~~~~
>  FAIL   create NULL path
> 	--- T560-lib-error.6.EXPECTED	2022-03-22 20:25:31.093160154 +0000
> 	+++ T560-lib-error.6.OUTPUT	2022-03-22 20:25:31.093160154 +0000
> 	@@ -1,3 +1,3 @@
> 	 == stdout ==
> 	 == stderr ==
> 	-Error: could not locate database.
> 	+Error: Cannot open database at CWD/home/.local/share/notmuch/default: No such file or directory.

I can duplicate this if I have a setting for MAILDIR in the environment.

I will send a patch clearing XDG_DATA_HOME and MAILDIR, but for now you
could add "unset MAILDIR" to test/test-vars.sh
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: