Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages

Subject: Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages

Date: Sun, 07 May 2023 14:13:09 -0600

To: mohkale@kisara.moe, notmuch@notmuchmail.org

Cc: Mohsin Kaleem

From: David Bremner

mohkale@kisara.moe writes:

> From: Mohsin Kaleem <mohkale@kisara.moe>
>

Apologies for the many messages. I think this commit message falls a bit
short of our usual standards (as well as a one line subject, we like to
have some kind of "why"). If you figure out the right answer to toggling
saved searches with :excluded properties, it might be worth explaining
your reasoning in the commit message. 
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

• Previous message (by thread): [PATCH v3] emacs: Add new option notmuch-search-hide-excluded

Thread:

• Mohsin Kaleem—[PATCH] emacs: add new option notmuch-search-exclude [inbox, notmuch::moreinfo, notmuch::patch, unread]
  • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
    • Mohsin Kaleem—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
        • Mohsin Kaleem—Re: [PATCH] emacs: add new option notmuch-search-exclude [attachment, inbox, unread]
          • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
            • Mohsin Kaleem—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
              • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
                • Mohsin Kaleem—Re: [PATCH] emacs: add new option notmuch-search-exclude [attachment, inbox, unread]
                  • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
                    • Mohsin Kaleem—Re: [PATCH] emacs: add new option notmuch-search-exclude [attachment, inbox, notmuch::moreinfo, notmuch::patch, unread]
                      • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
                        • Mohsin Kaleem—[PATCH 1/9] emacs: add new option notmuch-search-exclude [inbox, notmuch::moreinfo, notmuch::patch, unread]
                          • Mohsin Kaleem—[PATCH 2/9] docs: Update with notmuch-*-toggle-exclude [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH 2/9] docs: Update with notmuch-*-toggle-exclude [inbox, unread]
                          • Mohsin Kaleem—[PATCH 3/9] test: Fix Search handles subprocess error exit codes [inbox, notmuch::moreinfo, notmuch::patch, unread]
                          • Mohsin Kaleem—[PATCH 4/9] feat: Allow :exclude configuration in notmuch-hello [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH 4/9] feat: Allow :exclude configuration in notmuch-hello [inbox, unread]
                          • Mohsin Kaleem—[PATCH 5/9] feat: Add more interactive specs [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH 5/9] feat: Add more interactive specs [inbox, unread]
                          • Mohsin Kaleem—[PATCH 6/9] test: Add test cases for new exclude option [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • Tomi Ollila—Re: [PATCH 6/9] test: Add test cases for new exclude option [inbox, unread]
                              • Mohsin Kaleem—Re: [PATCH 6/9] test: Add test cases for new exclude option [inbox, unread]
                            • David Bremner—Re: [PATCH 6/9] test: Add test cases for new exclude option [inbox, unread]
                          • Mohsin Kaleem—[PATCH 7/9] test: Fix Navigation of notmuch-hello to search results [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH 7/9] test: Fix Navigation of notmuch-hello to search results [inbox, unread]
                          • Mohsin Kaleem—[PATCH 8/9] review: Rename variables to better express intention [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH 8/9] review: Rename variables to better express intention [inbox, unread]
                          • Mohsin Kaleem—[PATCH 9/9] build: Fix declare-function calls for updated functions [inbox, notmuch::moreinfo, notmuch::patch, unread]
                        • Mohsin Kaleem—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
                          • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
                            • David Bremner—Re: [PATCH] emacs: add new option notmuch-search-exclude [inbox, unread]
                        • mohkale@kisara.moe—[PATCH v2 0/3] emacs: Add new option notmuch-search-hide-excluded [inbox, unread]
                          • mohkale@kisara.moe—[PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded [inbox, unread]
                              • Mohsin Kaleem—Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded [inbox, unread]
                                • David Bremner—Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded [inbox, unread]
                            • David Bremner—Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded [inbox, unread]
                          • mohkale@kisara.moe—[PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages [inbox, unread]
                              • Mohsin Kaleem—Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages [inbox, unread]
                            • David Bremner—Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages [inbox, unread]
                          • mohkale@kisara.moe—[PATCH v2 3/3] test/emacs: Add test cases for notmuch-search-hide-excluded [inbox, notmuch::moreinfo, notmuch::patch, unread]
                            • David Bremner—Re: [PATCH v2 3/3] test/emacs: Add test cases for notmuch-search-hide-excluded [inbox, unread]
                          • mohkale@kisara.moe—[PATCH v3] emacs: Add new option notmuch-search-hide-excluded [inbox, notmuch::patch, notmuch::pushed, unread]