Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages

Subject: Re: [PATCH v2 2/3] emacs: Allow notmuch-saved-searches to hide excluded messages

Date: Sun, 10 Mar 2024 18:48:14 +0000

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Mohsin Kaleem


David Bremner <david@tethera.net> writes:

Hi, sorry, took me so long to get back to this XD. I've opted to squash
the 3 separate commits in this patch series into one commit so that
should address the commit message questions.

> mohkale@kisara.moe writes:
>
>> +  :excluded        Whether to show mail with excluded tags in the
>> +                   search. Possible values are `hide', `show',
>> +                   or nil. Nil means use the default value of
>> +                   `notmuch-search-hide-excluded'.
>
> So if I understand correctly, toggling excludes will not affect saved
> searches with a :excluded key. Is this what we want?
>
> I guess the alternative is to AND notmuch-search-hide-excluded with the
> value derived from the saved-search?

I think this is the last pending question. This shouldn't be the case.
When you open a search from notmuch saved searches it'll contain
whatever value you specify in :excluded but you can interactively change
that with the new toggle-exclude commands and the workflow should be as
you expect. I did notice while testing this that notmuch-jump currently
doesn't respect the exclude option you add to saved searches but I've
addressed that in this next patch version.


-- 
Mohsin Kaleem
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: