Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Subject: Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Date: Sun, 15 Jan 2012 11:55:01 +0000

To: Pieter Praet, Jani Nikula

Cc: Notmuch Mail

From: David Edmondson

On Sat, 14 Jan 2012 10:18:46 +0100, Pieter Praet <pieter@praet.org> wrote:
> Does this really warrant a v2, or might we simply leave it as yet
> another victim for Tomi's uncrustify-for-elisp [1] ?

Pushing incorrectly indented code should be banned, in my opinion[1]. I'd
be tempted to have some pre-commit hooks to detect it.

Footnotes: 
[1]  Though I've done it myself.

• Previous message (by thread): Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

Thread:

• Jani Nikula—[PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    • Jani Nikula—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      • Jani Nikula—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        • Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
          • Tomi Ollila—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
            • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
              • Tomi Ollila—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
              • Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
  • Jani Nikula—[PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Dmitry Kurochkin—Re: [PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    • Dmitry Kurochkin—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      • Jani Nikula—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        • Austin Clements—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    • Austin Clements—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    • David Bremner—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    • Pieter Praet—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
      • Pieter Praet—[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, unread]
        • Xavier Maillard—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, signed, unread]
          • Xavier Maillard—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • Tomi Ollila—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
          • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • Pieter Praet—[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
              • David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                • Jani Nikula—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                  • David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                    • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, signed, unread]
                      • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                        • Dmitry Kurochkin—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                  • Tomi Ollila—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                    • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
              • David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                  • Pieter Praet—[PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
                    • David Edmondson—Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, signed, unread]
                    • David Bremner—Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
            • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
          • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
              • Pieter Praet—[PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
                • David Edmondson—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, signed, unread]
                • Tomi Ollila—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, unread]
                • David Bremner—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]