On Sat, 28 Jan 2012 13:14:45 -0400, David Bremner <david@tethera.net> wrote: > On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote: > > On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote: > > > > Sometimes someone (Dmitry?) sent patches that separated a small functional > > change, and the big non-functional indentation change it caused, > > separately. Would you prefer (or tolerate ;) that style? > > Hmm, that might be nicer, I'm not 100% sure. > > I wouldn't say it's mandatory for a patch like this (and I'd say other > peoples views on what's easy to review are at least as important as mine > here). Each patch should be valid in the repository without any following patches (preceding are obviously okay). Incorrect indentation would disqualify a patch from being 'valid', so it shouldn't be accepted.