Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Subject: Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Date: Sat, 14 Jan 2012 10:14:57 +0100

On Fri, 13 Jan 2012 08:23:55 +0000, David Edmondson <dme@dme.org> wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Less code, same results, without sacrificing readability.
> 
> +1, but why not replace non-branching `if' with `when' as well?

I was planning to do that when the `unless' patch was accepted,
but after reading Xavier and Tomi's replies, I've changed my mind.

Looking at "subr.el", it's actually more efficient to use `if'
(implemented in C) instead of `when' (a macro, which essentially
runs "if conf (progn ...)".

The amount of non-branching "(if COND (progn ..."  statements is very
limited though, so if inclined to "fix" them nonetheless, a patch
follows (relative to the previous one!).

Peace

-- 
Pieter

Previous message (by thread): Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

Thread:

Jani Nikula—[PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::obsolete, notmuch::patch, unread]
- Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
  - Jani Nikula—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    - Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
  - Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    - Jani Nikula—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      - Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        Tomi Ollila—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        Tomi Ollila—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
- Jani Nikula—[PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Dmitry Kurochkin—Re: [PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
  - Austin Clements—Re: [PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
- Jani Nikula—[PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Dmitry Kurochkin—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    - Jani Nikula—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      - Austin Clements—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
  - Austin Clements—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
  - David Bremner—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
  - Pieter Praet—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    - Pieter Praet—[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
      - Dmitry Kurochkin—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, unread]
      - Xavier Maillard—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
      - David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, signed, unread]
        Xavier Maillard—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        Tomi Ollila—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        Pieter Praet—[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Jani Nikula—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, signed, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Tomi Ollila—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Pieter Praet—[PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
        David Edmondson—Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, signed, unread]
        David Bremner—Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
      - David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
        Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
        Pieter Praet—[PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
        David Edmondson—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, signed, unread]
        Tomi Ollila—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, unread]
        David Bremner—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]