Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Subject: Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..."

Date: Sat, 14 Jan 2012 10:18:46 +0100

To: David Edmondson, Jani Nikula

Cc: Notmuch Mail

From: Pieter Praet


On Fri, 13 Jan 2012 16:06:17 +0000, David Edmondson <dme@dme.org> wrote:
> On Thu, 12 Jan 2012 18:33:06 +0100, Pieter Praet <pieter@praet.org> wrote:
> > Less code, same results, without sacrificing readability.
> 
> Does this change correctly re-indent the line following the if/unless?

It does...

Or so I thought... I appear to have forgotten to correct the indentation
@ `notmuch-hello-insert-tags'.


Unfortunately git doesn't provide a way to diff the whitespace itself;
  (eg. "git diff --word-diff=color --word-diff-regex='[ \t]*'")

Setting "color.diff.whitespace" (and perhaps expanding the scope of
"core.whitespace") only colorizes *erroneous* whitespace...


Does this really warrant a v2, or might we simply leave it as yet
another victim for Tomi's uncrustify-for-elisp [1] ?


Peace

-- 
Pieter

[1] id:"yf639bkexs3.fsf@taco2.nixu.fi"

Thread: