Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

Date: Sat, 28 Jan 2012 13:14:45 -0400

To: Jani Nikula

Cc: Notmuch Mail

From: David Bremner

On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula <jani@nikula.org> wrote:
> On Jan 28, 2012 2:41 PM, "David Bremner" <david@tethera.net> wrote:
> 
> Sometimes someone (Dmitry?) sent patches that separated a small functional
> change, and the big non-functional indentation change it caused,
> separately. Would you prefer (or tolerate ;) that style?

Hmm, that might be nicer, I'm not 100% sure.

I wouldn't say it's mandatory for a patch like this (and I'd say other
peoples views on what's easy to review are at least as important as mine
here).

d

• Previous message (by thread): Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..."

Thread:

• Jani Nikula—[PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    • Jani Nikula—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      • Jani Nikula—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        • Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
          • Tomi Ollila—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
            • Dmitry Kurochkin—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
              • Tomi Ollila—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
              • Austin Clements—Re: [PATCH] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
  • Jani Nikula—[PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Dmitry Kurochkin—Re: [PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    • Austin Clements—Re: [PATCH v2] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    • Dmitry Kurochkin—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
      • Jani Nikula—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
        • Austin Clements—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    • Austin Clements—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
    • David Bremner—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, unread]
    • Pieter Praet—Re: [PATCH v3] emacs: support "notmuch new" as a notmuch-poll-script [inbox, notmuch::review, unread]
      • Pieter Praet—[PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        • Dmitry Kurochkin—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, unread]
        • Xavier Maillard—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, signed, unread]
          • Xavier Maillard—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • Tomi Ollila—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
          • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • Pieter Praet—[PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
              • David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                • Jani Nikula—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                  • David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                    • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, signed, unread]
                      • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                        • Dmitry Kurochkin—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                  • Tomi Ollila—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                    • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
              • David Bremner—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
                  • Pieter Praet—[PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
                    • David Edmondson—Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, signed, unread]
                    • David Bremner—Re: [PATCH v2] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." [inbox, unread]
            • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
        • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
          • Pieter Praet—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]
            • David Edmondson—Re: [PATCH] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, signed, unread]
              • Pieter Praet—[PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
                • David Edmondson—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, signed, unread]
                • Tomi Ollila—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, notmuch::review, unread]
                • David Bremner—Re: [PATCH v2] emacs: globally replace non-branching "(if (not ..." with "(unless ..." [inbox, unread]