Hi Daniel. On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe <daniel@schoepe.org> wrote: > Hi Dmitry, > > On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > > There are some trailing whitespaces in the tests. > > those are also produced by the various notmuch-hello functions, and are > also in the existing tests. If someone is bothered by this, it should be > fixed in a separate patch. > I only meant trailing whitespaces in test/emacs file in the lines added by the patch. Trailing whitespaces in expected results are obviously fine. > > > > Also, please consider moving the hello sections tests to a separate file > > (emacs-hello-sections, perhaps?). I am worried that test/emacs file > > becomes too big. And we will probably add more notmuch-hello > > section-related tests in the future. > > I think it's better to split it up into more than just > emacs-hello-sections and emacs, as there are also quite a few tests > relating solely to, e.g., -show or -search. > I think splitting emacs tests based on -hello, -show and -search views is a good idea. Splitting existing tests is out of scope of this patch. But I think it may be a good opportunity to add a new file with -hello tests. > Anyhow, I'll send another rebased version fixing conflicts with the > search-interface changes. > Thanks, I will try to review it soon. Regards, Dmitry > Cheers, > Daniel