Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

Subject: Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello

Date: Wed, 07 Mar 2012 20:53:48 +0100

To: David Bremner, Dmitry Kurochkin, notmuch@notmuchmail.org

On Thu, 01 Mar 2012 08:36:33 -0400, David Bremner <david@tethera.net> wrote:
> 
> Pushed, finally. Thanks for both of your hard work on this.
>

625 lines changed (425 added, 200 removed), in a *single* commit ?

It's a useful bit of functionality which definitely deserves to be
included, and I do recognize and appreciate all the hard work that
went into it, but... am I the only one who was a bit surprised to
see this patch being applied [1] as-is?

> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Peace

-- 
Pieter

[1] commit 3557acab

Previous message (by thread): Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

Thread:

Daniel Schoepe—[PATCH v4 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
- Daniel Schoepe—[PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  - Michal Sojka—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::review, unread]
    - Daniel Schoepe—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
      - Michal Sojka—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, unread]
    - Daniel Schoepe—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
- Daniel Schoepe—[PATCH v4 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
- Daniel Schoepe—[PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Daniel Schoepe—[PATCH v5 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Schoepe—[PATCH v5 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Schoepe—[PATCH] emacs: NEWS entry for user-defined sections [inbox, notmuch::doc, notmuch::patch, notmuch::stale, unread]
  - Daniel Schoepe—Re: [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
    - Michal Sojka—Re: [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      - Daniel Schoepe—[PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—[PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        David Bremner—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        Michal Sojka—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Michal Sojka—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        Daniel Schoepe—[PATCH v7 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::obsolete, notmuch::patch, unread]
        Daniel Schoepe—[PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, notmuch::obsolete, notmuch::patch, unread]
        Dmitry Kurochkin—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, notmuch::review, unread]
        Daniel Schoepe—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, signed, unread]
        Daniel Schoepe—[PATCH v8 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—[PATCH v8 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        Daniel Schoepe—[PATCH v8 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        Dmitry Kurochkin—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, unread]
        Daniel Schoepe—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, signed, unread]
        Daniel Schoepe—[PATCH v6 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        Michal Sojka—[PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        David Edmondson—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, signed, unread]
        Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, signed, unread]
        David Edmondson—Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        Daniel Schoepe—Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
- Dmitry Kurochkin—[PATCH v9 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Dmitry Kurochkin—[PATCH v9 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Dmitry Kurochkin—[PATCH v9 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
- Dmitry Kurochkin—[PATCH v10 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Dmitry Kurochkin—[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
    - David Bremner—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      - Michal Sojka—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      - Pieter Praet—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        David Bremner—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Dmitry Kurochkin—[PATCH v10 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::pushed, notmuch::test, unread]
  - Michal Sojka—Re: [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
    - Michal Sojka—[PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
      - Mark Walters—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]
        Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, notmuch::review, signed, unread]
        Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, signed, unread]
      - Dmitry Kurochkin—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]
      - David Bremner—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]