Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello

Subject: Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello

Date: Sat, 09 Jul 2011 19:07:13 +0200

To: Michal Sojka, notmuch@notmuchmail.org

Cc:

On Sat, 09 Jul 2011 01:00:03 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> Yes, this is definitely a good idea. My last comment to the patch is
> that I do not like the use of plists in customization interface. It is
> especially weird in the case of boolean options like hide-if-empty,
> because they actually have three states: disabled, off and on. And this
> make not a lot of sense.

I just realized we overlooked the simplest solution: Changing the (boolean ..)
elements to (const :tag "..." t) elements resolves this nicely.

I'll send a new version shortly.

Cheers,
Daniel

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

Thread:

Daniel Schoepe—[PATCH v4 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
- Daniel Schoepe—[PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  - Michal Sojka—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::review, unread]
    - Daniel Schoepe—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
      - Michal Sojka—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, unread]
    - Daniel Schoepe—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
- Daniel Schoepe—[PATCH v4 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
- Daniel Schoepe—[PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Daniel Schoepe—[PATCH v5 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Schoepe—[PATCH v5 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Schoepe—[PATCH] emacs: NEWS entry for user-defined sections [inbox, notmuch::doc, notmuch::patch, notmuch::stale, unread]
  - Daniel Schoepe—Re: [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
    - Michal Sojka—Re: [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      - Daniel Schoepe—[PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—[PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        David Bremner—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        Michal Sojka—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Michal Sojka—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        Daniel Schoepe—[PATCH v7 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::obsolete, notmuch::patch, unread]
        Daniel Schoepe—[PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, notmuch::obsolete, notmuch::patch, unread]
        Dmitry Kurochkin—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, notmuch::review, unread]
        Daniel Schoepe—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, signed, unread]
        Daniel Schoepe—[PATCH v8 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—[PATCH v8 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        Daniel Schoepe—[PATCH v8 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
        Dmitry Kurochkin—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, unread]
        Daniel Schoepe—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, signed, unread]
        Daniel Schoepe—[PATCH v6 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        Michal Sojka—[PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
        David Edmondson—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, signed, unread]
        Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, signed, unread]
        David Edmondson—Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        Daniel Schoepe—Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
- Dmitry Kurochkin—[PATCH v9 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Dmitry Kurochkin—[PATCH v9 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Dmitry Kurochkin—[PATCH v9 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
- Dmitry Kurochkin—[PATCH v10 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Dmitry Kurochkin—[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
    - David Bremner—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      - Michal Sojka—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Dmitry Kurochkin—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      - Pieter Praet—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        Daniel Schoepe—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        David Bremner—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  - Dmitry Kurochkin—[PATCH v10 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::pushed, notmuch::test, unread]
  - Michal Sojka—Re: [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
    - Michal Sojka—[PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
      - Mark Walters—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]
        Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, notmuch::review, signed, unread]
        Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, signed, unread]
      - Dmitry Kurochkin—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]
      - David Bremner—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]