On Wed, 07 Mar 2012 20:53:48 +0100, Pieter Praet <pieter@praet.org> wrote: > On Thu, 01 Mar 2012 08:36:33 -0400, David Bremner <david@tethera.net> wrote: > > > > Pushed, finally. Thanks for both of your hard work on this. > > > > 625 lines changed (425 added, 200 removed), in a *single* commit ? > > It's a useful bit of functionality which definitely deserves to be > included, and I do recognize and appreciate all the hard work that > went into it, but... am I the only one who was a bit surprised to > see this patch being applied [1] as-is? I think it is hard to split this patch up into meaningful smaller pieces, since it mainly moves parts from notmuch-hello into separate functions and adds some defcustoms. So, the main opportunities for splitting would be to do this moving of code into functions one function per commit and to put the defcustoms and their quite lengthy documentation in a separate commit (which would leave you with an intermediate version that's seriously lacking in documentation). I'm not sure if those two things are that useful, but if there's consensus that the patch shouldn't stay in the way it is, I can give it a shot (although it'd be a lot of tedious work). Cheers, Daniel