Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello

Subject: Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello

Date: Thu, 24 Nov 2011 15:01:01 +0100

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Daniel Schoepe

On Thu, 24 Nov 2011 09:54:50 -0400, David Bremner <david@tethera.net> wrote:
> On Mon, 10 Oct 2011 15:39:41 +0200, Daniel Schoepe <daniel@schoepe.org> wrote:
> > From: Daniel Schoepe <daniel.schoepe@googlemail.com>
> > 
> > This patch makes the notmuch-hello screen fully customizable
> > by allowing the user to add and remove arbitrary sections. It
> > also provides some convenience functions for constructing sections,
> > e.g. showing the unread message count for each tag.
> > 
> 
> Yow, that is a big patch, I think it needs some more review.

Yes; Unfortunately I didn't manage to come up with good partitioning
into smaller patches, because the changes are quite interconnected.

Is there something I can do to help with the review?

I think there's also one performance improvement written by Michal
Sojka, that isn't included in this version yet, but since patches are
getting applied more timely now, I guess that can be merged afterwards.

Cheers,
Daniel

• Previous message (by thread): Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections

Thread:

• Daniel Schoepe—[PATCH v4 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
  • Daniel Schoepe—[PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
    • Michal Sojka—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::review, unread]
      • Daniel Schoepe—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
        • Michal Sojka—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, unread]
      • Daniel Schoepe—Re: [PATCH v4 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
  • Daniel Schoepe—[PATCH v4 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
  • Daniel Schoepe—[PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
    • Daniel Schoepe—[PATCH v5 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Schoepe—[PATCH v5 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
    • Daniel Schoepe—[PATCH] emacs: NEWS entry for user-defined sections [inbox, notmuch::doc, notmuch::patch, notmuch::stale, unread]
    • Daniel Schoepe—Re: [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
      • Michal Sojka—Re: [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        • Daniel Schoepe—[PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
          • Daniel Schoepe—[PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
            • David Bremner—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
              • Daniel Schoepe—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
                • Michal Sojka—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
                • Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
                  • Michal Sojka—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
            • Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
              • Dmitry Kurochkin—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
              • Daniel Schoepe—Re: [PATCH v6 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
                • Daniel Schoepe—[PATCH v7 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::obsolete, notmuch::patch, unread]
                  • Daniel Schoepe—[PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, notmuch::obsolete, notmuch::patch, unread]
                    • Dmitry Kurochkin—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, notmuch::review, unread]
                      • Daniel Schoepe—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, signed, unread]
                        • Daniel Schoepe—[PATCH v8 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
                          • Daniel Schoepe—[PATCH v8 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
                          • Daniel Schoepe—[PATCH v8 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
                        • Dmitry Kurochkin—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, unread]
                          • Daniel Schoepe—Re: [PATCH v7 2/2] emacs: Tests for user-defined sections [inbox, signed, unread]
          • Daniel Schoepe—[PATCH v6 2/2] emacs: Tests for user-defined sections [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
          • Michal Sojka—[PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
            • David Edmondson—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, signed, unread]
              • Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in [inbox, signed, unread]
          • David Edmondson—Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
            • Daniel Schoepe—Re: [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
  • Dmitry Kurochkin—[PATCH v9 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
    • Dmitry Kurochkin—[PATCH v9 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
    • Dmitry Kurochkin—[PATCH v9 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, notmuch::test, unread]
  • Dmitry Kurochkin—[PATCH v10 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
    • Dmitry Kurochkin—[PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
      • David Bremner—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        • Michal Sojka—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
          • Dmitry Kurochkin—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
        • Pieter Praet—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
          • Daniel Schoepe—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, signed, unread]
          • David Bremner—Re: [PATCH v10 1/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
    • Dmitry Kurochkin—[PATCH v10 2/2] emacs: Tests for user-defined sections [inbox, notmuch::emacs, notmuch::feature, notmuch::patch, notmuch::pushed, notmuch::test, unread]
    • Michal Sojka—Re: [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello [inbox, unread]
      • Michal Sojka—[PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
        • Mark Walters—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]
          • Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, notmuch::review, signed, unread]
            • Daniel Schoepe—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, signed, unread]
        • Dmitry Kurochkin—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]
        • David Bremner—Re: [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections [inbox, unread]