On Thu, 24 Nov 2011, Daniel Schoepe wrote: > On Thu, 24 Nov 2011 09:54:50 -0400, David Bremner <david@tethera.net> wrote: > > On Mon, 10 Oct 2011 15:39:41 +0200, Daniel Schoepe <daniel@schoepe.org> wrote: > > > From: Daniel Schoepe <daniel.schoepe@googlemail.com> > > > > > > This patch makes the notmuch-hello screen fully customizable > > > by allowing the user to add and remove arbitrary sections. It > > > also provides some convenience functions for constructing sections, > > > e.g. showing the unread message count for each tag. > > > > > > > Yow, that is a big patch, I think it needs some more review. I use this patch on a daily basis. There is probably some space for improvements, especially in the coding style, but I'd like to see a more experience elisp hacker than me looking at it. > Yes; Unfortunately I didn't manage to come up with good partitioning > into smaller patches, because the changes are quite interconnected. > > Is there something I can do to help with the review? > > I think there's also one performance improvement written by Michal > Sojka, that isn't included in this version yet, Yes, that's true. I'm aware of one bug in this improvement. I usually start notmuch by emacsclient -c -a '' -e "(notmuch)" and the bug is that sometimes the emacs window disappear immediately after appearing. This did not happen without this improvement and I guess it is caused by some unexpected return value, perhaps in the code which determines the initial position of the point. Cheers, -Michal