Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections

Date: Sat, 28 Jan 2012 22:30:57 +0100

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Daniel Schoepe


Hi Dmitry,

On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> There are some trailing whitespaces in the tests.

those are also produced by the various notmuch-hello functions, and are
also in the existing tests. If someone is bothered by this, it should be
fixed in a separate patch.

> 
> Also, please consider moving the hello sections tests to a separate file
> (emacs-hello-sections, perhaps?).  I am worried that test/emacs file
> becomes too big.  And we will probably add more notmuch-hello
> section-related tests in the future.

I think it's better to split it up into more than just
emacs-hello-sections and emacs, as there are also quite a few tests
relating solely to, e.g., -show or -search.

Anyhow, I'll send another rebased version fixing conflicts with the
search-interface changes.

Cheers,
Daniel
part-000.sig (application/pgp-signature)

Thread: