Re: [PATCH 1/4] test: Add `test_emacs_expect_t'.

Subject: Re: [PATCH 1/4] test: Add `test_emacs_expect_t'.

Date: Tue, 17 Jan 2012 13:24:55 +0000

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: David Edmondson


(And one for the list...)

On Tue, 17 Jan 2012 17:09:35 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> -1
> 
> This is not what I suggested.  I do not like the approach when a single
> function is used to both declare a subtest and test for result (as
> opposed to test_begin_subtest).  The fact that it is possible to write
> tests in two different ways makes it hard to maintain and improve the
> test framework (one example would be known broken test support).  I
> consider the proper way to write tests to be using the
> test_begin_subtest function.  Other functions are not currently
> deprecated, but I am against adding new code that make the situation
> worse.

Sigh. Okay.

> Also, please consider documenting new functions in README.

Missed that, sorry.
part-000.sig (application/pgp-signature)

Thread: