Re: [PATCH] emacs: fix a bug introduced by the recent search cleanups.

Subject: Re: [PATCH] emacs: fix a bug introduced by the recent search cleanups.

Date: Thu, 02 Aug 2012 22:00:10 -0300

To: Mark Walters, Jani Nikula, Austin Clements, notmuch@notmuchmail.org

Cc:

Mark Walters <markwalters1009@gmail.com> writes:

> In commit 5d0883e the function notmuch-search-next-thread was changed.
> In particular it only goes to the next message if there is a next
> message. This breaks notmuch-show-archive-thread-then-next. Fix this
> by going to the "next" message whenever we are on a current message.

Pushed, 

d

Previous message (by thread): Re: [PATCH] emacs: fix a bug introduced by the recent search cleanups.

Thread:

Austin Clements—[PATCH 0/8] JSON-based search-mode [inbox, unread]
- Austin Clements—[PATCH 1/8] emacs: Clean up notmuch-search-show-result [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result [inbox, unread]
      - Tomi Ollila—Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result [inbox, unread]
  - Mark Walters—Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result [inbox, unread]
- Austin Clements—[PATCH 2/8] emacs: Separate search line parsing and display [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 3/8] emacs: Move search-target logic to `notmuch-search-show-result' [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 3/8] emacs: Move search-target logic to `notmuch-search-show-result' [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 3/8] emacs: Move search-target logic to `notmuch-search-show-result' [inbox, unread]
- Austin Clements—[PATCH 4/8] emacs: Helper for reporting search parsing errors [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 4/8] emacs: Helper for reporting search parsing errors [inbox, notmuch::review, unread]
- Austin Clements—[PATCH 5/8] emacs: Pass plist to `notmuch-search-show-result' [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 6/8] test: New test for incremental search output parsing [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 7/8] emacs: Implement an incremental JSON parser [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 7/8] emacs: Implement an incremental JSON parser [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 7/8] emacs: Implement an incremental JSON parser [inbox, unread]
- Austin Clements—[PATCH 8/8] emacs: Switch from text to JSON format for search results [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 8/8] emacs: Switch from text to JSON format for search results [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH 8/8] emacs: Switch from text to JSON format for search results [inbox, unread]
- Tomi Ollila—Re: [PATCH 0/8] JSON-based search-mode [inbox, notmuch::review, unread]
- Austin Clements—[PATCH v2 0/9] JSON-based search-mode [inbox, unread]
  - Austin Clements—[PATCH v2 1/9] emacs: Clean up notmuch-search-show-result [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 2/9] emacs: Separate search line parsing and display [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 3/9] emacs: Helper for reporting search parsing errors [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 4/9] emacs: Move search-target logic to `notmuch-search-show-result' [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 5/9] emacs: Pass plist to `notmuch-search-show-result' [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 6/9] test: New test for incremental search output parsing [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 7/9] emacs: Implement an incremental JSON parser [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 8/9] emacs: Switch from text to JSON format for search results [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Austin Clements—[PATCH v2 9/9] News for JSON-based search [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH v2 0/9] JSON-based search-mode [inbox, notmuch::review, unread]
    - Austin Clements—Re: [PATCH v2 0/9] JSON-based search-mode [inbox, unread]
      - Mark Walters—Re: [PATCH v2 0/9] JSON-based search-mode [inbox, notmuch::review, unread]
- Austin Clements—[PATCH v3 0/9] JSON-based search-mode [inbox, unread]
  - Austin Clements—[PATCH v3 1/9] emacs: Clean up notmuch-search-show-result [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    - David Bremner—Re: [PATCH v3 1/9] emacs: Clean up notmuch-search-show-result [inbox, unread]
  - Austin Clements—[PATCH v3 2/9] emacs: Separate search line parsing and display [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 3/9] emacs: Helper for reporting search parsing errors [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 4/9] emacs: Move search-target logic to `notmuch-search-show-result' [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 5/9] emacs: Pass plist to `notmuch-search-show-result' [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 6/9] test: New test for incremental search output parsing [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 7/9] emacs: Implement an incremental JSON parser [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 8/9] emacs: Switch from text to JSON format for search results [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v3 9/9] News for JSON-based search [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Mark Walters—Re: [PATCH v3 0/9] JSON-based search-mode [inbox, notmuch::review, unread]
  - Tomi Ollila—Re: [PATCH v3 0/9] JSON-based search-mode [inbox, notmuch::review, unread]
- Austin Clements—[PATCH v4 0/8] emacs: JSON-based search cleanups [inbox, unread]
  - Austin Clements—[PATCH v4 1/8] emacs: Record thread search result object in a text property [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v4 2/8] emacs: Use text properties instead of overlays for tag coloring [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v4 3/8] emacs: Update tags by rewriting the search result line in place [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v4 4/8] emacs: Use result text properties for search result iteration [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v4 5/8] emacs: Replace other search text properties with result property [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v4 6/8] emacs: Allow custom tags formatting [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—[PATCH v4 7/8] emacs: Fix navigation of multi-line search result formats [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
    - Jani Nikula—Re: [PATCH v4 7/8] emacs: Fix navigation of multi-line search result formats [inbox, unread]
      - Mark Walters—[PATCH] emacs: fix a bug introduced by the recent search cleanups. [inbox, notmuch::patch, notmuch::pushed, unread]
        Jani Nikula—Re: [PATCH] emacs: fix a bug introduced by the recent search cleanups. [inbox, notmuch::review, unread]
        Austin Clements—Re: [PATCH] emacs: fix a bug introduced by the recent search cleanups. [inbox, notmuch::review, unread]
        David Bremner—Re: [PATCH] emacs: fix a bug introduced by the recent search cleanups. [inbox, unread]
  - Austin Clements—[PATCH v4 8/8] News for search cleanups [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Austin Clements—Re: [PATCH v4 0/8] emacs: JSON-based search cleanups [inbox, unread]
  - Mark Walters—Re: [PATCH v4 0/8] emacs: JSON-based search cleanups [inbox, notmuch::review, unread]
  - Jameson Graef Rollins—Re: [PATCH v4 0/8] emacs: JSON-based search cleanups [inbox, notmuch::review, signed, unread]
  - David Bremner—Re: [PATCH v4 0/8] emacs: JSON-based search cleanups [inbox, unread]