On Wed, Jul 04 2012, Austin Clements <amdragon@MIT.EDU> wrote: > Quoth Mark Walters on Jul 04 at 8:53 am: >> On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote: >> > This simplifies the code and makes it no longer cubic in the number of >> > result fields. >> >> This looks good to me and all tests pass, and I agree that this patch >> can be pushed independently of the later patches in the series. >> >> My one comment is that I, as a lisp beginner, found the use of "format" >> as a function and a variable confusing (particularly as I had not come >> across the dolist macro and that use really makes format look like a >> function). > > I can see how that would be confusing. Unless this version of the > series is somehow perfect, I'll rename it in the second version. > Perhaps result-format for the loop variable and spec for the format > string argument? There are 'format' variables elsewhere too -- on those places it could be renamed as 'format-string' (as used else-elsewhere and the format documentation refers to STRING). As an analogy to that the 'format' in this particular dolist usage could be 'format-pair' ? (but anything goes, even the current 'format'). Tomi > >> Best wishes >> >> Mark