Re: [PATCH] contrib/nmbug: new script for sharing tags with a given prefix.

Subject: Re: [PATCH] contrib/nmbug: new script for sharing tags with a given prefix.

Date: Mon, 07 Nov 2011 14:58:53 +0200

To: David Bremner,

Cc: David Bremner

From: Tomi Ollila

On Sun,  6 Nov 2011 20:59:46 -0400, David Bremner <> wrote:
> From: David Bremner <>
> The main idea is consider the notmuch database as analogous to the
> work-tree. A bare git repo is maintained in the users home directory,
> with a tree of the form tags/$message-id/$tag
> Like notmuch and git, we have a set of subcommnds, mainly modelled on
> git.
> The most important commands are
>     commit	xapian -> git
>     checkout	git -> xapian
>     merge	fetched git + git -> xapian
>     status	find differences between xapian, git, and remote git.
> There are also some convenience wrappers around git commands.
> In order to encode tags (viewed as octet sequences) into filenames,
> we whitelist a smallish set of characters and %hex escape anything outside.
> The prefix is omitted in git, which lets one save and restore to
> different prefixes (although this is only lightly tested).
> ---
> Many things have changed, time for a repost. It no long needs the
> "restore --match" patches. 

Good work. Could you do some simple things to help our reviewer's work:

*) consistent spacing (around '='s and '{':s (and '=>':s) etc.
*) consistent amount of newlines
*) consitent quoting (use same ':s or ":s in similar context)
*) M-x whitespace-cleanup (or M-x delete-trailing-whitespace) in pivot...
*) something else than @ in m@ ... @x (at least in unpack_diff_lines) (confuses viewers)