Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil.

Subject: Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil.

Date: Mon, 31 Oct 2011 07:51:14 -0300

To: Jani Nikula

Cc: notmuch@notmuchmail.org

From: David Bremner

On Mon, 31 Oct 2011 09:20:13 +0000, Jani Nikula <jani@nikula.org> wrote:
> 
> Hi David, this patch (commit 1dedfc90f6eee7cad10f1a1ceb39a7a1c4dbd1b1)
> broke my build with:
> 
> CXX -O2 lib/libnotmuch.so.2.0.0

Can you try "make V=1"? The output should look like

g++ lib/filenames.o lib/string-list.o lib/libsha1.o lib/message-file.o lib/messages.o lib/sha1.o lib/tags.o lib/database.o lib/directory.o lib/index.o lib/message.o lib/query.o lib/thread.o  -Wl,--as-needed -pthread -lgmime-2.4 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0   -ltalloc   -lxapian -shared -Wl,--version-script=notmuch.sym,-soname=libnotmuch.so.2 -o lib/libnotmuch.so.2.0.0 -L./util -lutil

The last part, "-L./util -lutil" is where all those symbols are.

d

• Previous message (by thread): Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix.

Thread:

• David Bremner—[PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
  • David Bremner—[PATCH] xregcomp: don't consider every regex compilation failure an internal error. [inbox, notmuch::feature, notmuch::patch, notmuch::pushed, unread]
    • David Bremner— [inbox, unread]
      • David Bremner—[PATCH 1/4] notmuch-restore: add tests for new --match command line argument. [inbox, notmuch::feature, notmuch::patch, notmuch::stale, unread]
      • David Bremner—[PATCH 2/4] notmuch-restore: implement argument parsing for --match [inbox, notmuch::feature, notmuch::patch, notmuch::stale, unread]
      • David Bremner—[PATCH 3/4] test/dump-restore: add tests for notmuch restore --match [inbox, notmuch::feature, notmuch::patch, notmuch::stale, unread]
      • David Bremner—[PATCH 4/4] notmuch-restore: implement --match functionality [inbox, notmuch::feature, notmuch::patch, notmuch::stale, unread]
        • David Bremner—Experimental Tag Sharing [inbox, notmuch::feature, unread]
          • David Bremner—[PATCH] contrib/nmbug: new script for sharing tags with prefix notmuch:: [inbox, notmuch::feature, notmuch::obsolete, notmuch::patch, unread]
            • Ali Polatel—Re: [PATCH] contrib/nmbug: new script for sharing tags with prefix notmuch:: [inbox, signed, unread]
              • David Bremner—Re: [PATCH] contrib/nmbug: new script for sharing tags with prefix notmuch:: [inbox, unread]
                • Ali Polatel—Re: [PATCH] contrib/nmbug: new script for sharing tags with prefix notmuch:: [inbox, signed, unread]
            • David Bremner—[PATCH] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, notmuch::obsolete, notmuch::patch, unread]
              • Tomi Ollila—Re: [PATCH] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, notmuch::review, unread]
              • David Bremner—[PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, notmuch::patch, notmuch::pushed, unread]
                • Jameson Graef Rollins—Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, signed, unread]
                  • David Bremner—Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, unread]
                    • Jameson Graef Rollins—Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, signed, unread]
                      • David Bremner—Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, unread]
                • David Bremner—Re: [PATCH v3] contrib/nmbug: new script for sharing tags with a given prefix. [inbox, unread]
          • David Bremner—[PATCH v2] contrib/nmbug: new script for sharing tags with prefix notmuch:: [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—Re: Experimental Tag Sharing [inbox, signed, unread]
            • David Bremner—Re: Experimental Tag Sharing [inbox, signed, unread]
        • David Bremner—[PATCH] docs: man, online help, and NEWS updated for notmuch restore --match [inbox, notmuch::obsolete, notmuch::patch, unread]
          • Jameson Graef Rollins—[PATCH] Fix formatting for restore and dump help documentation. [inbox, notmuch::doc, notmuch::obsolete, notmuch::patch, unread]
            • David Bremner—Re: [PATCH] Fix formatting for restore and dump help documentation. [inbox, unread]
  • David Bremner—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [attachment, inbox, notmuch::patch, notmuch::pushed, signed, unread]
  • Austin Clements—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, unread]
  • Jameson Graef Rollins—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, signed, unread]
    • David Bremner—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, signed, unread]
  • Jani Nikula—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, unread]
    • David Bremner—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, unread]
    • Jameson Graef Rollins—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, signed, unread]
      • Jani Nikula—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH] xutil.c: remove duplicate copies, create new library libutil.a to contain xutil. [inbox, unread]