On Tue, Feb 04 2014, "W. Trevor King" <wking@tremily.us> wrote: > On Mon, Feb 03, 2014 at 10:44:39PM +0200, Tomi Ollila wrote: >> having notmuch patch email as expected test output feels a bit >> confusing to me -- especially as 'git grep' may catch some of the >> (possibly future-outdated) content... > > There were two very similar patches with filename attachments in the > corpus, so I used them for the tests ;). I can convert that test to > use emacs_fcc_message or some other auto-generated content if you'd > prefer. You're right; corpus seems to be full of notmuch patch emails... ... and (although?) (just noticed)... $ grep '^ *[+-].*\<if\>' test/* test/*/* test/emacs.expected-output/attachment:+ if (pw_buf_size == -1) pw_buf_size = 64; test/emacs.expected-output/attachment:+ if (pw_buf_size == -1) pw_buf_size = 64; ... I am not giving much resistance to keep the patch as it is :D > > Cheers, > Trevor > Tomi