Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Date: Mon, 3 Feb 2014 17:32:46 -0800

To: Mark Walters

Cc: notmuch@notmuchmail.org

From: W. Trevor King

On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote:
> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote:
> > I think we should only display/use the content-description if it
> > exists and is non-empty.
> 
> Sounds good to me.  I'll queue this and a test for v2.

Rather than patching this in Emacs, maybe we should collapse the “not
set” and “set to empty string” cases in notmuch-show.c?  I can't think
of any reasons why someone would want to distinguish those two cases,
and it's easier all around if we standardize the representation as far
upstream as possible.

Thoughts?
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy

• Previous message (by thread): Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Thread:

• W. Trevor King—[RFC] Content-Description when naming MIME parts in Emacs mode [inbox, signed, unread]
  • David Bremner—Re: [RFC] Content-Description when naming MIME parts in Emacs mode [inbox, unread]
  • Mark Walters—Re: [RFC] Content-Description when naming MIME parts in Emacs mode [inbox, unread]
    • W. Trevor King—[PATCH 0/2] [inbox, unread]
      • W. Trevor King—[PATCH 1/2] notmuch-show: Add content-description output pair [inbox, notmuch::feature, notmuch::moreinfo, notmuch::patch, unread]
      • W. Trevor King—[PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, notmuch::emacs, notmuch::moreinfo, notmuch::patch, unread]
        • Mark Walters—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
          • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
            • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
              • David Bremner—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
                • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
                  • Mark Walters—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
                    • David Bremner—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
            • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
              • Mark Walters—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
        • Tomi Ollila—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
          • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
            • Tomi Ollila—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
      • David Bremner—Re: [PATCH 0/2] [inbox, unread]