Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Date: Sun, 09 Feb 2014 08:53:35 -0400

To: Mark Walters, W. Trevor King

Cc: notmuch@notmuchmail.org

From: David Bremner

Mark Walters <markwalters1009@gmail.com> writes:


> Looking at the code for that pathway we use
> g_mime_message_get_recipients followed by
> internet_address_list_to_string and we only output a cc: pair if this is
> non-null (which means we had an address)
>
> In light of that I think changing the cli to only output
> content-description if non-null seems consistent.
>

OK, I can live with it. Thanks for the analysis Mark.

Cheers,

d

• Previous message (by thread): Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons

Thread:

• W. Trevor King—[RFC] Content-Description when naming MIME parts in Emacs mode [inbox, signed, unread]
  • David Bremner—Re: [RFC] Content-Description when naming MIME parts in Emacs mode [inbox, unread]
  • Mark Walters—Re: [RFC] Content-Description when naming MIME parts in Emacs mode [inbox, unread]
    • W. Trevor King—[PATCH 0/2] [inbox, unread]
      • W. Trevor King—[PATCH 1/2] notmuch-show: Add content-description output pair [inbox, notmuch::feature, notmuch::moreinfo, notmuch::patch, unread]
      • W. Trevor King—[PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, notmuch::emacs, notmuch::moreinfo, notmuch::patch, unread]
        • Mark Walters—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
          • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
            • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
              • David Bremner—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
                • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
                  • Mark Walters—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
                    • David Bremner—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
            • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
              • Mark Walters—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
        • Tomi Ollila—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
          • W. Trevor King—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, signed, unread]
            • Tomi Ollila—Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons [inbox, unread]
      • David Bremner—Re: [PATCH 0/2] [inbox, unread]