Re: [PATCH 1/9] test: move test_ruby() inside the only client

Subject: Re: [PATCH 1/9] test: move test_ruby() inside the only client

Date: Sun, 02 May 2021 21:28:03 +0300

To: David Bremner, Felipe Contreras, notmuch@notmuchmail.org

Cc:

On Sun, May 02 2021, David Bremner wrote:

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Not much point in polluting the main library, and also will be useful to
>> modify it in tandem with the tests.
>>
>
> I can live with this change.

I'd say strong LGTM :D

Tomi

>
> d
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms

Thread:

Felipe Contreras—[PATCH 0/9] test: ruby: several cleanups and simplifications [inbox, unread]
- Felipe Contreras—[PATCH 1/9] test: move test_ruby() inside the only client [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 1/9] test: move test_ruby() inside the only client [inbox, unread]
    - Tomi Ollila—Re: [PATCH 1/9] test: move test_ruby() inside the only client [inbox, unread]
- Felipe Contreras—[PATCH 2/9] test: ruby: refactor test_ruby() [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 2/9] test: ruby: refactor test_ruby() [inbox, unread]
- Felipe Contreras—[PATCH 3/9] test: ruby: simplify MAIL_DIR check [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 3/9] test: ruby: simplify MAIL_DIR check [inbox, unread]
- Felipe Contreras—[PATCH 4/9] test: ruby: simplify MAIL_DIR initialization [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 4/9] test: ruby: simplify MAIL_DIR initialization [inbox, unread]
- Felipe Contreras—[PATCH 5/9] test: ruby: simplify test_ruby() [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 5/9] test: ruby: simplify test_ruby() [inbox, unread]
    - Felipe Contreras—Re: [PATCH 5/9] test: ruby: simplify test_ruby() [inbox, unread]
- Felipe Contreras—[PATCH 6/9] test: ruby: use much more standard puts [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 6/9] test: ruby: use much more standard puts [inbox, unread]
- Felipe Contreras—[PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
    - Tomi Ollila—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
      - David Bremner—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
        Felipe Contreras—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
    - Felipe Contreras—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, notmuch::patch, notmuch::pushed, unread]
- Felipe Contreras—[PATCH 8/9] test: ruby: don't use instance variables [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 8/9] test: ruby: don't use instance variables [inbox, unread]
- Felipe Contreras—[PATCH 9/9] test: ruby: simplify output comparison [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 9/9] test: ruby: simplify output comparison [inbox, unread]
- David Bremner—Re: [PATCH 0/9] test: ruby: several cleanups and simplifications [inbox, unread]