Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms

Subject: Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms

Date: Wed, 05 May 2021 19:29:45 -0300

To: Tomi Ollila, Felipe Contreras, notmuch@notmuchmail.org

Cc:

Tomi Ollila <tomi.ollila@iki.fi> writes:
>
> I am convinced that this is good change (like all the other changes
> in this series). 
>
> Every now and then I encounter ruby code, and have seen syntax like
> `@q.search_threads.each do |t|` been used, so more exposure to that
> syntax is good thing (for everyone (IMO))
>

OK, I've applied the patch (and the others in the series). I have my
(already expressed) reservations, but I don't want to stand in the way
of progress on the ruby bindings.

d

_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms

Thread:

Felipe Contreras—[PATCH 0/9] test: ruby: several cleanups and simplifications [inbox, unread]
- Felipe Contreras—[PATCH 1/9] test: move test_ruby() inside the only client [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 1/9] test: move test_ruby() inside the only client [inbox, unread]
    - Tomi Ollila—Re: [PATCH 1/9] test: move test_ruby() inside the only client [inbox, unread]
- Felipe Contreras—[PATCH 2/9] test: ruby: refactor test_ruby() [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 2/9] test: ruby: refactor test_ruby() [inbox, unread]
- Felipe Contreras—[PATCH 3/9] test: ruby: simplify MAIL_DIR check [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 3/9] test: ruby: simplify MAIL_DIR check [inbox, unread]
- Felipe Contreras—[PATCH 4/9] test: ruby: simplify MAIL_DIR initialization [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 4/9] test: ruby: simplify MAIL_DIR initialization [inbox, unread]
- Felipe Contreras—[PATCH 5/9] test: ruby: simplify test_ruby() [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 5/9] test: ruby: simplify test_ruby() [inbox, unread]
    - Felipe Contreras—Re: [PATCH 5/9] test: ruby: simplify test_ruby() [inbox, unread]
- Felipe Contreras—[PATCH 6/9] test: ruby: use much more standard puts [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 6/9] test: ruby: use much more standard puts [inbox, unread]
- Felipe Contreras—[PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
    - Tomi Ollila—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
      - David Bremner—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
        Felipe Contreras—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
    - Felipe Contreras—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, notmuch::patch, notmuch::pushed, unread]
- Felipe Contreras—[PATCH 8/9] test: ruby: don't use instance variables [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 8/9] test: ruby: don't use instance variables [inbox, unread]
- Felipe Contreras—[PATCH 9/9] test: ruby: simplify output comparison [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 9/9] test: ruby: simplify output comparison [inbox, unread]
- David Bremner—Re: [PATCH 0/9] test: ruby: several cleanups and simplifications [inbox, unread]