On Wed, May 5, 2021 at 5:29 PM David Bremner <david@tethera.net> wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
> >
> > I am convinced that this is good change (like all the other changes
> > in this series).
> >
> > Every now and then I encounter ruby code, and have seen syntax like
> > `@q.search_threads.each do |t|` been used, so more exposure to that
> > syntax is good thing (for everyone (IMO))
>
> OK, I've applied the patch (and the others in the series). I have my
> (already expressed) reservations, but I don't want to stand in the way
> of progress on the ruby bindings.

If you have reservations about the code, feel free to let me know and
I would try to address them in further rerolls of the patch series.

I'm a long term git contributor, so I'm used to several rounds of
reviews, a bit of pushback isn't going to deter me.

But at least the patches that you pushed I don't think could have any issues.

Let's see the rest.

Cheers.

-- 
Felipe Contreras
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org