Re: [PATCH 5/9] test: ruby: simplify test

Re: [PATCH 5/9] test: ruby: simplify test_ruby()

Subject: Re: [PATCH 5/9] test: ruby: simplify test_ruby()

Date: Sun, 2 May 2021 16:53:59 -0500

On Sun, May 2, 2021 at 6:02 AM David Bremner <david@tethera.net> wrote:
>
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
> > We always do test_expect_equal_file, so do it in test_ruby() directly.
> >
> > The only subtest where we don't (get non-existent file) can be easily
> > modified.
>
> I'm slightly hesitent since every other test ends with test_expect_*.
> OTOH it is self contained within this one file so I guess I can live
> with this change.

The test could be named test_ruby_expect and be passed the EXPECTED
file, or something.

-- 
Felipe Contreras
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Previous message (by thread): Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms

Thread:

Felipe Contreras—[PATCH 0/9] test: ruby: several cleanups and simplifications [inbox, unread]
- Felipe Contreras—[PATCH 1/9] test: move test_ruby() inside the only client [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 1/9] test: move test_ruby() inside the only client [inbox, unread]
    - Tomi Ollila—Re: [PATCH 1/9] test: move test_ruby() inside the only client [inbox, unread]
- Felipe Contreras—[PATCH 2/9] test: ruby: refactor test_ruby() [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 2/9] test: ruby: refactor test_ruby() [inbox, unread]
- Felipe Contreras—[PATCH 3/9] test: ruby: simplify MAIL_DIR check [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 3/9] test: ruby: simplify MAIL_DIR check [inbox, unread]
- Felipe Contreras—[PATCH 4/9] test: ruby: simplify MAIL_DIR initialization [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 4/9] test: ruby: simplify MAIL_DIR initialization [inbox, unread]
- Felipe Contreras—[PATCH 5/9] test: ruby: simplify test_ruby() [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 5/9] test: ruby: simplify test_ruby() [inbox, unread]
    - Felipe Contreras—Re: [PATCH 5/9] test: ruby: simplify test_ruby() [inbox, unread]
- Felipe Contreras—[PATCH 6/9] test: ruby: use much more standard puts [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 6/9] test: ruby: use much more standard puts [inbox, unread]
- Felipe Contreras—[PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
    - Tomi Ollila—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
      - David Bremner—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
        Felipe Contreras—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, unread]
    - Felipe Contreras—Re: [PATCH 7/9] test: ruby: use much more standard Ruby idioms [inbox, notmuch::patch, notmuch::pushed, unread]
- Felipe Contreras—[PATCH 8/9] test: ruby: don't use instance variables [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 8/9] test: ruby: don't use instance variables [inbox, unread]
- Felipe Contreras—[PATCH 9/9] test: ruby: simplify output comparison [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 9/9] test: ruby: simplify output comparison [inbox, unread]
- David Bremner—Re: [PATCH 0/9] test: ruby: several cleanups and simplifications [inbox, unread]